Page MenuHome

Fix missing view3d updates after recent NC_SPACE notifier filters
ClosedPublic

Authored by Philipp Oeser (lichtwerk) on Mar 18 2021, 1:43 PM.

Details

Summary

Since rB46aa70cb486d: UI: Avoid unnecessary redraws of unrelated editors on space changes, using NC_SPACE | ND_SPACE_VIEW3D as notifier is
restricted to space data as a reference. This was still used though for
RNA updates in other places (namely rna_camera, rna_scene,
rna_animviz), and passing NULL would automatically set the notifier
reference to the owner id. Above commit would happily filter these out,
leading to missing refreshes.

Now use more specific notifiers (in case of animviz a new
ND_DRAW_ANIMVIZ was added).

This was reported for Camera background images btw.
Fixes T86670.

Diff Detail

Repository
rB Blender

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Mar 18 2021, 1:43 PM
Philipp Oeser (lichtwerk) created this revision.

Looks good (mostly, small documentation change requested).

source/blender/windowmanager/WM_types.h
373

Please add a comment explaining what this is and when it should be used.
The notifiers are chronically under-documented, we better start addressing that.

This revision is now accepted and ready to land.Mar 18 2021, 2:26 PM