Paths

Table of Contentst

Differential D10759

VSE|Feature: Add strip.move_to(meta) function
ClosedPublic
Actions

Authored by Félix (Miadim) on Mar 18 2021, 2:39 PM.

Tags

None

Subscribers

None

Details

Reviewers

Richard Antalik (ISS)

Commits

rB4158405c0b9d: VSE: Add move_to_meta RNA API function

Summary

Usage:

strip.move_to(meta)

Diff Detail

Repository

Branch

strip.move_to (branched from master)

Build Status

Buildable 13605
Build 13605: arc lint + arc unit

Event Timeline

Félix (Miadim) requested review of this revision.Mar 18 2021, 2:39 PM

Félix (Miadim) created this revision.

Harbormaster completed remote builds in B13591: Diff 35341.Mar 18 2021, 2:39 PM

Fix strip moving to meta

Harbormaster completed remote builds in B13595: Diff 35349.Mar 18 2021, 6:31 PM

Félix (Miadim) edited the summary of this revision. (Show Details)Mar 18 2021, 6:33 PM

Use seq_find_seqbase to find the appropriate seqbase

Harbormaster completed remote builds in B13598: Diff 35352.Mar 18 2021, 8:01 PM

Richard Antalik (ISS) added inline comments.Mar 18 2021, 9:23 PM

source/blender/sequencer/intern/utils.c
588 ↗	(On Diff #35352)	I wanted to suggest better name and I found function that does same thing - `SEQ_get_seqbase_by_seq()` Sorry I did not look properly first time but I wasn't 100% sure it was there still.

Use SEQ_get_seqbase_by_seq

Harbormaster completed remote builds in B13605: Diff 35375.Mar 19 2021, 9:51 AM

Will commit with slight correction of function names I did not catch these initially.

This revision is now accepted and ready to land.Mar 19 2021, 11:38 PM

Closed by commit rB4158405c0b9d: VSE: Add move_to_meta RNA API function (authored by Felix Gremse (felix), committed by Richard Antalik (ISS)). · Explain WhyMar 20 2021, 1:42 AM

This revision was automatically updated to reflect the committed changes.

Richard Antalik (ISS) added a commit: rB4158405c0b9d: VSE: Add move_to_meta RNA API function.

Revision Contents
Changeset List

Path

Size

source/

blender/

makesrna/

intern/

rna_sequencer_api.c

20 lines

sequencer/

1 line

intern/

23 lines

1 line

Diff 35375

source/blender/makesrna/intern/rna_sequencer_api.c

Loading...

source/blender/sequencer/SEQ_edit.h

Loading...

source/blender/sequencer/intern/strip_edit.c

Loading...

source/blender/sequencer/intern/utils.h

Loading...