Fix T86677: select grouped in node editor crashes without active node
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Mar 18 2021, 5:05 PM.

Details

Reviewers

Hans Goudey (HooglyBoogly)

Maniphest Tasks

T86677: Blender crashes after pressing ctrl+shift+g in a new geo nodes tree

Commits

rB1e1d96f0a87c: Fix T86677: select grouped in node editor crashes without active node

Summary

This was reported for geometry nodes, but was true for all nodetrees
(e.g. after deleting the active node). Geometry node trees just made
this more obvious since they start without an active node to begin with.

Fix provided by @Leon Schittek (lone_noel), thx!

Diff Detail

Repository

rB Blender

Branch

T86677 (branched from master)

Build Status

Buildable 13594
Build 13594: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Mar 18 2021, 5:05 PM

Philipp Oeser (lichtwerk) created this revision.

Harbormaster completed remote builds in B13594: Diff 35346.Mar 18 2021, 5:05 PM

I checked other code using nodeGetActive and it always seemed to do a NULL check, so this makes sense. More conceptually, I don't think it always makes sense to guarantee there is an active node, so this makes sense on a design level too IMO. Thanks!

This revision is now accepted and ready to land.Mar 18 2021, 5:10 PM

Closed by commit rB1e1d96f0a87c: Fix T86677: select grouped in node editor crashes without active node (authored by Philipp Oeser (lichtwerk)). · Explain WhyMar 18 2021, 5:17 PM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rB1e1d96f0a87c: Fix T86677: select grouped in node editor crashes without active node.