Page MenuHome
Differential D10763

Fix T86701 : Geometry nodes Cube and UV Sphere mesh size
ClosedPublic
Actions

Authored by Pratik Borhade (PratikPB2123) on Mar 18 2021, 9:20 PM.

Details

Reviewers
Hans Goudey (HooglyBoogly)
Maniphest Tasks
T86701: Geometry nodes Cube and UV Sphere mesh size
Commits
rB7e3efac9a857: Fix T86701: Geometry nodes Cube and UV Sphere mesh size
Summary

Fix T86701 .

  • parameter value changed ( see : loc_eul_size_to_mat4 function call ) .

Diff Detail

Repository
rB Blender

Event Timeline

Pratik Borhade (PratikPB2123) requested review of this revision.Mar 18 2021, 9:20 PM
Pratik Borhade (PratikPB2123) created this revision.
Pratik Borhade (PratikPB2123) edited the summary of this revision. (Show Details)Mar 18 2021, 9:23 PM
Hans Goudey (HooglyBoogly) accepted this revision.Mar 18 2021, 9:53 PM

Thanks!

This revision is now accepted and ready to land.Mar 18 2021, 9:53 PM
Closed by commit rB7e3efac9a857: Fix T86701: Geometry nodes Cube and UV Sphere mesh size (authored by Pratik Borhade (PratikPB2123), committed by Hans Goudey (HooglyBoogly)). · Explain WhyMar 18 2021, 10:01 PM
This revision was automatically updated to reflect the committed changes.
Hans Goudey (HooglyBoogly) added a commit: rB7e3efac9a857: Fix T86701: Geometry nodes Cube and UV Sphere mesh size.
Hans Goudey (HooglyBoogly) added a comment.EditedMar 18 2021, 10:02 PM

float3 has a constructor for an int, so in the commit I used that instead of 1.0f. It's just a bit shorter that way.
EDIT: Looks like I only changed one of them, oh well, it's only 3 characters

Revision Contents
Changeset List

PathSize
source/
blender/
nodes/
geometry/
nodes/
2 lines
2 lines

Diff 35353

View Options

source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_cube.cc

Loading...
View Options

source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_uv_sphere.cc

Loading...