Page MenuHome
Differential D10771

Fix T86666: Using Lasso and Circle select tools, objects which are not visible due to camera clipping are also selected
ClosedPublic
Actions

Authored by Germano Cavalcante (mano-wii) on Mar 19 2021, 7:14 PM.

Details

Reviewers
Campbell Barton (campbellbarton)
Maniphest Tasks
T86666: Using Lasso and Circle select tools, objects which are not visible due to camera clipping are also selected.
Commits
rB9baf39c8dade: Fix T86666: Lasso and Circle select tools selecting objects behind clip_min
Summary

Although it works apparently well in most cases, the algorithm to detect
if a point is within the limits of the camera does not work in othographic
mode and does not consider the clip_end.

This patch corrects the algorithm and adds the option
V3D_PROJ_TEST_CLIP_FAR.

Ref T86666

Diff Detail

Repository
rB Blender
Branch
master
Build Status
Buildable 13655
Build 13655: arc lint + arc unit

Event Timeline

Germano Cavalcante (mano-wii) requested review of this revision.Mar 19 2021, 7:14 PM
Germano Cavalcante (mano-wii) created this revision.
Harbormaster completed remote builds in B13614: Diff 35390.Mar 19 2021, 7:14 PM
Germano Cavalcante (mano-wii) updated this revision to Diff 35460.EditedMar 22 2021, 5:06 AM
  • vec4[3] -> fz
Harbormaster completed remote builds in B13651: Diff 35460.Mar 22 2021, 5:06 AM
Germano Cavalcante (mano-wii) planned changes to this revision.Mar 22 2021, 5:23 AM
Germano Cavalcante (mano-wii) updated this revision to Diff 35461.Mar 22 2021, 6:38 AM
  • Remove the use of V3D_PROJ_TEST_CLIP_FAR (but leave the code for possible future use)

Better not to change current behavior.

Harbormaster completed remote builds in B13652: Diff 35461.Mar 22 2021, 6:39 AM
Germano Cavalcante (mano-wii) updated this revision to Diff 35471.Mar 22 2021, 3:04 PM
  • micro optimization
Harbormaster completed remote builds in B13655: Diff 35471.Mar 22 2021, 3:04 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 22 2021, 4:46 PM
Closed by commit rB9baf39c8dade: Fix T86666: Lasso and Circle select tools selecting objects behind clip_min (authored by Germano Cavalcante (mano-wii)). · Explain Why
This revision was automatically updated to reflect the committed changes.
Germano Cavalcante (mano-wii) added a commit: rB9baf39c8dade: Fix T86666: Lasso and Circle select tools selecting objects behind clip_min.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
include/
16 lines
space_view3d/
51 lines
16 lines

Diff 35471

View Options

source/blender/editors/include/ED_view3d.h

Loading...
View Options

source/blender/editors/space_view3d/view3d_project.c

Loading...
View Options

source/blender/editors/space_view3d/view3d_select.c

Loading...