Fix T86809: Action Editor header not display the right action in certain scenarios
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Mar 23 2021, 5:08 PM.

Details

Reviewers

Sybren A. Stüvel (sybren)
Julian Eisel (Severin)

Maniphest Tasks

T86809: Action Editor doesn't update until highlighted

Commits

rBdb0b1cab1f8c: Fix T86809: Action Editor header not display the right action in certain…

Summary

If a new action is created (e.g. by inserting keyframes), the header was
not garuanteed to display the right action.
Notifiers were fine here, redraw took place, the editors action was just
not set soon enough for the drawing.

Now make sure this is set correctly by ensuring the animation context is
right (same as the other editor regions do before drawing).

Diff Detail

Repository: rB Blender

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Mar 23 2021, 5:08 PM

Philipp Oeser (lichtwerk) created this revision.

Harbormaster completed remote builds in B13685: Diff 35517.Mar 23 2021, 5:08 PM

Philipp Oeser (lichtwerk) added projects: Animation & Rigging, User Interface.Mar 23 2021, 5:09 PM

I don't think this is the right solution. Draw functions should just draw, and not make up for some missing tagging somewhere else.
But then again, action_channel_region_draw also calls ANIM_animdata_get_context(), and with that ensures that its data is correct. I don't like this at all, as "get_xxx" functions should not have such side-effects, but it's how things are at the moment, and just calling that same function does solve this issue.

This revision is now accepted and ready to land.Apr 19 2021, 4:26 PM

Julian Eisel (Severin) resigned from this revision.Apr 19 2021, 6:20 PM

Closed by commit rBdb0b1cab1f8c: Fix T86809: Action Editor header not display the right action in certain… (authored by Philipp Oeser (lichtwerk)). · Explain WhyApr 20 2021, 10:05 AM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rBdb0b1cab1f8c: Fix T86809: Action Editor header not display the right action in certain….