Page MenuHome

Color Management: Dreadful alternative hack to fix View Transform for the VSE in 2.93
AbandonedPublic

Authored by Peter Fog (tintwotin) on Mar 24 2021, 11:09 AM.
Tokens
"Love" token, awarded by Andrea_Monzini."100" token, awarded by mal_cando."Like" token, awarded by nilserik."Love" token, awarded by fodevaux."Love" token, awarded by jayrajkharvadi."Like" token, awarded by dddjef."Love" token, awarded by Draise."Like" token, awarded by looch.

Details

Summary

As mentioned in T86622, having Filmic set as default View Transform setting, will for most VSE users result in a 6 minutes export will take a whooping 26 minutes and the resulting colors will be flat/greyed out.

As I do not think it is fair to users to let Blender continuously be released with a destructive default setting like that, here is a quick fix which can be used in 2.93 until @Brecht Van Lommel (brecht) decides what to do about this problem.

This hack piggybacks the Use Frame Rate import setting, which will copy the fps of the first imported Movie strip to the Render Properties. This hack does the same for the View Transform setting by setting it to standard when the first strip Movie strip is imported.

As mentioned I hope Brecht comes up with something better, if nothing else, this patch can be seen as the dreadful alternative, if nothing else is done about this problem.

Code is copy-pasted from versioning code.

I will not do revisions of this code, so if you guys need changes, you are free to do so.

Good luck.

Diff Detail

Event Timeline

Peter Fog (tintwotin) requested review of this revision.Mar 24 2021, 11:09 AM
Peter Fog (tintwotin) created this revision.
Peter Fog (tintwotin) edited the summary of this revision. (Show Details)
Peter Fog (tintwotin) edited the summary of this revision. (Show Details)Mar 27 2021, 11:39 PM

Does this work when the OCIO env variable is set ?

This should use IMB_colormanagement_display_get_default_view_transform_name rather than Standard.

Beyond that, I think this is a video sequencer module decision and will leave it up to @Richard Antalik (ISS). It seems like a reasonable workaround.

T86622 is not waiting on a design decision by the way, I proposed a design that I think is fine, it's a matter of implementing it.

This patch didn't make it into 2.93. As I do not have anymore time or motivation for a continued investment in the Blender project, I'm giving up on this patch for now.