Geometry Nodes: Rename attribute domains.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Mar 24 2021, 12:42 PM.

Details

Reviewers

Hans Goudey (HooglyBoogly)
Dalai Felinto (dfelinto)

Maniphest Tasks

T86818: Domain renames

Commits

rC3c4d1c123b74: Geometry Nodes: rename attribute domains
rB28cf851a5c31: Geometry Nodes: rename attribute domains

Summary

This patch renames two domains:

Polygon -> Face
Corner -> Face Corner

For the change from polygon to face I did a "deep rename", where I updated all (most?) cases where we refer to the attribute domain in code as well.
The change from Corner to Face Corner is only a ui change. I did not see a real need to update all the code for that. I tried it in a few places, but it does not seem to improve the code, more on the contrary.

Diff Detail

Repository

rB Blender

Branch

domain-rename (branched from master)

Build Status

Buildable 13700
Build 13700: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Mar 24 2021, 12:42 PM

Jacques Lucke (JacquesLucke) created this revision.

Harbormaster completed remote builds in B13700: Diff 35545.Mar 24 2021, 12:42 PM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Mar 24 2021, 12:47 PM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)

Jacques Lucke (JacquesLucke) added a task: T86818: Domain renames.

Jacques Lucke (JacquesLucke) added reviewers: Hans Goudey (HooglyBoogly), Dalai Felinto (dfelinto).

Good choice about not changing the code for the "Corner" rename

This revision is now accepted and ready to land.Mar 24 2021, 1:25 PM

The rename is perfect. I do find the order of the domains a bit arbitrary (it can be tackled as a separate commit though, so I'm +1 this.
Basically I find it more natural to see face corners after the faces. Or at the very least after the points. As it is now seems random (after edge but before corners)

Closed by commit rB28cf851a5c31: Geometry Nodes: rename attribute domains (authored by Jacques Lucke (JacquesLucke)). · Explain WhyMar 25 2021, 12:03 PM

This revision was automatically updated to reflect the committed changes.

Jacques Lucke (JacquesLucke) added a commit: rB28cf851a5c31: Geometry Nodes: rename attribute domains.

Jacques Lucke (JacquesLucke) mentioned this in rBf7fa0d3974c5: Geometry Nodes: change order of domains in drop down.

Stefan Werner (swerner) added a commit: rC3c4d1c123b74: Geometry Nodes: rename attribute domains.Jun 2 2021, 9:18 PM