Page MenuHome
Differential D10817

Fix T86796: moving the cursor in the UV Editor does not take aspect into account
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Mar 25 2021, 1:29 PM.

Details

Reviewers
Campbell Barton (campbellbarton)
Germano Cavalcante (mano-wii)
Maniphest Tasks
T86796: 2D Cursor "runs away" from mouse when dragging in UV Editor
Commits
rB56df673be271: Fix T86796: moving the cursor in the UV Editor does not take aspect into
Summary

UV coords are scaled by aspects (see UVsToTransData). This also applies
for the Cursor in the UV Editor which also means that for display and
when the cursor coords are flushed (new 'recalcData_cursor_image' was
added for this), these need to be converted each time.

This flags moving the cursor in the Image Editor T_2D_EDIT with the
following benefits:

  • dissallowing e.g. Z constraints
  • improving the header display
    • it should not use scene units
    • now respects if we are moving in pixel coords or not

Diff Detail

Repository
rB Blender
Branch
T86796 (branched from master)
Build Status
Buildable 13719
Build 13719: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Mar 25 2021, 1:29 PM
Philipp Oeser (lichtwerk) created this revision.
Harbormaster completed remote builds in B13719: Diff 35575.Mar 25 2021, 1:30 PM
Philipp Oeser (lichtwerk) added projects: Restricted Project, Modeling.Mar 25 2021, 1:30 PM
Campbell Barton (campbellbarton) accepted this revision.Mar 25 2021, 2:13 PM
Campbell Barton (campbellbarton) added inline comments.
source/blender/editors/transform/transform_mode_translate.c
64

This doesn't seem correct, unit system shouldn't apply to images?

This revision is now accepted and ready to land.Mar 25 2021, 2:13 PM
Campbell Barton (campbellbarton) added inline comments.Mar 25 2021, 2:14 PM
source/blender/editors/transform/transform_mode_translate.c
64

Edit, if this is needed - there should be an explanation why image editor uses scene units.

Philipp Oeser (lichtwerk) updated this revision to Diff 35578.Mar 25 2021, 2:47 PM

flag moving image editor cursor T_2D_EDIT

Harbormaster completed remote builds in B13721: Diff 35578.Mar 25 2021, 2:47 PM
Philipp Oeser (lichtwerk) edited the summary of this revision. (Show Details)Mar 25 2021, 2:48 PM
Closed by commit rB56df673be271: Fix T86796: moving the cursor in the UV Editor does not take aspect into (authored by Philipp Oeser (lichtwerk)). · Explain WhyMar 25 2021, 3:38 PM
This revision was automatically updated to reflect the committed changes.
Philipp Oeser (lichtwerk) mentioned this in rBa9cd90135afe: Make moving the cursor in UV Editor a 2d edit transform.
Philipp Oeser (lichtwerk) added a commit: rB56df673be271: Fix T86796: moving the cursor in the UV Editor does not take aspect into.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
transform/
17 lines
7 lines
6 lines

Diff 35575

View Options

source/blender/editors/transform/transform_convert.c

Loading...
View Options

source/blender/editors/transform/transform_convert_cursor.c

Loading...
View Options

source/blender/editors/transform/transform_mode_translate.c

Loading...