Page MenuHome
Differential D10823

Cleanup: Remove SEQ_CURRENT_BEGIN macro
ClosedPublic
Actions

Authored by Richard Antalik (ISS) on Mar 25 2021, 9:55 PM.

Details

Reviewers
Campbell Barton (campbellbarton)
Commits
rBb128ffd53970: Cleanup: Remove SEQ_CURRENT_BEGIN macro
Summary

Use LISTBASE_FOREACH instead.
SEQ_CURRENT_BEGIN did null checks, so now these must be explicit.

Diff Detail

Repository
rB Blender
Branch
arcpatch-D10823 (branched from master)
Build Status
Buildable 13834
Build 13834: arc lint + arc unit

Event Timeline

Richard Antalik (ISS) requested review of this revision.Mar 25 2021, 9:55 PM
Richard Antalik (ISS) created this revision.
Harbormaster completed remote builds in B13731: Diff 35596.Mar 25 2021, 9:55 PM
Richard Antalik (ISS) mentioned this in D10337: VSE: New iterator design.Mar 26 2021, 11:19 AM
Campbell Barton (campbellbarton) accepted this revision.Mar 31 2021, 9:14 AM
Campbell Barton (campbellbarton) added a subscriber: Campbell Barton (campbellbarton).
Campbell Barton (campbellbarton) added inline comments.
source/blender/editors/space_sequencer/sequencer_draw.c
107–108

Should be removed as well.

This revision is now accepted and ready to land.Mar 31 2021, 9:14 AM
Richard Antalik (ISS) updated this revision to Diff 35792.Mar 31 2021, 9:25 AM
Richard Antalik (ISS) marked an inline comment as done.

Remove missed undef for SEQ_CURRENT_END

Harbormaster completed remote builds in B13834: Diff 35792.Mar 31 2021, 9:25 AM
Closed by commit rBb128ffd53970: Cleanup: Remove SEQ_CURRENT_BEGIN macro (authored by Richard Antalik (ISS)). · Explain WhyMar 31 2021, 9:30 AM
This revision was automatically updated to reflect the committed changes.
Richard Antalik (ISS) added a commit: rBb128ffd53970: Cleanup: Remove SEQ_CURRENT_BEGIN macro.

Revision Contents
Changeset List

PathSize
1 line
source/
blender/
blenloader/
intern/
5 lines
editors/
space_sequencer/
2 lines
21 lines
3 lines
12 lines
51 lines
sequencer/
9 lines

Diff 35792

View Options

.clang-format

Loading...
View Options

source/blender/blenloader/intern/versioning_legacy.c

Loading...
View Options

source/blender/editors/space_sequencer/sequencer_draw.c

Loading...
View Options

source/blender/editors/space_sequencer/sequencer_edit.c

Loading...
View Options

source/blender/editors/space_sequencer/sequencer_modifier.c

Loading...
View Options

source/blender/editors/space_sequencer/sequencer_proxy.c

Loading...
View Options

source/blender/editors/space_sequencer/sequencer_select.c

Loading...
View Options

source/blender/sequencer/SEQ_iterator.h

Loading...