Page MenuHome
Differential D10826

Fix T86932: Curve: pick shortest path missing update of active point drawing
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Mar 26 2021, 10:43 AM.

Details

Reviewers
Clément Foucault (fclem)
Sergey Sharybin (sergey)
Maniphest Tasks
T86932: Regression: Curve edit mode, late visual update of active point
Commits
rB663a82b10d23: Fix T86932: Curve: pick shortest path missing update of active point drawing
Summary

For curves, we need to tag the curve ID_RECALC_COPY_ON_WRITE for batch
cache update (same as in rB24b2fe50f3ec: Fix T64829: Active point of Curve objects is not displayed correctly).

Diff Detail

Repository
rB Blender

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Mar 26 2021, 10:43 AM
Philipp Oeser (lichtwerk) created this revision.
Harbormaster completed remote builds in B13742: Diff 35612.Mar 26 2021, 10:43 AM
Philipp Oeser (lichtwerk) added projects: EEVEE & Viewport, Dependency Graph.Mar 26 2021, 10:44 AM
Vyacheslav (hitrpr) awarded a token.Mar 27 2021, 6:08 PM
Sergey Sharybin (sergey) added a comment.Mar 29 2021, 10:10 AM

This might be fine for now, but the proper fix sounds to be to fix it from the depsgraph side (which currently for whatever reason explicitly ignores CoW update on shading recalc).

This revision was not accepted when it landed; it landed in state Needs Review.Apr 6 2021, 11:17 AM
Closed by commit rB663a82b10d23: Fix T86932: Curve: pick shortest path missing update of active point drawing (authored by Philipp Oeser (lichtwerk)). · Explain Why
This revision was automatically updated to reflect the committed changes.
Philipp Oeser (lichtwerk) added a commit: rB663a82b10d23: Fix T86932: Curve: pick shortest path missing update of active point drawing.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
curve/
2 lines

Diff 35890

View Options

source/blender/editors/curve/editcurve_select.c

Loading...