Geometry info -> tangent: Make consistent with Cycles for hair
AbandonedPublic
Actions

Authored by Mikhail Matrosov (ktdfly) on Mar 28 2021, 1:12 PM.

Details

Reviewers

Brecht Van Lommel (brecht)
Clément Foucault (fclem)

Group Reviewers

EEVEE & Viewport

Commits

rBa294670bacb1: EEVEE: Geometry info -> tangent: Make consistent with Cycles for hair

Summary

Changes output for geometry info node in Eevee to be consistent with Cycles (w/o osl)

Before this patch Eevee outputs Z-tangent even for hair. This patch changes it to output hair tangent (growth direction). Hair tangent is impossible to derive otherwise from normal or view direction.

Diff Detail

Repository: rB Blender

Event Timeline

Mikhail Matrosov (ktdfly) requested review of this revision.Mar 28 2021, 1:12 PM

Mikhail Matrosov (ktdfly) created this revision.

Mikhail Matrosov (ktdfly) created this object with edit policy "Administrators".

Mikhail Matrosov (ktdfly) mentioned this in D10829: Hair info: tangent (direction).Mar 28 2021, 1:17 PM

Brecht Van Lommel (brecht) requested changes to this revision.Mar 28 2021, 3:47 PM

Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).

Brecht Van Lommel (brecht) added inline comments.

source/blender/gpu/shaders/material/gpu_shader_material_geometry.glsl
40–41	Put these lines in `#else`.

This revision now requires changes to proceed.Mar 28 2021, 3:47 PM

jack conradsen (STANN.co) added a subscriber: jack conradsen (STANN.co).Mar 28 2021, 3:48 PM

jack conradsen (STANN.co) awarded a token.Mar 28 2021, 7:10 PM

Mikhail Matrosov (ktdfly) updated this revision to Diff 35687.Mar 28 2021, 9:34 PM

Mikhail Matrosov (ktdfly) marked an inline comment as done.

I'll leave the final review and commit to Clément.

Awaiting this fix for an animation project. @Clément Foucault (fclem) Thanks for the good work!

Sergey Sharybin (sergey) changed the edit policy from "Administrators" to "All Users".May 19 2021, 12:34 PM

Commited as rBa294670bacb1

Clément Foucault (fclem) added a commit: rBa294670bacb1: EEVEE: Geometry info -> tangent: Make consistent with Cycles for hair.May 19 2021, 12:39 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

gpu/

shaders/

material/

gpu_shader_material_geometry.glsl

4 lines

Diff 35681

View Options

source/blender/gpu/shaders/material/gpu_shader_material_geometry.glsl

Geometry info -> tangent: Make consistent with Cycles for hairAbandonedPublicActions