Paths

Table of Contentst

Differential D10855

LibOverride: Initial dedicated view in the Outliner.
ClosedPublic
Actions

Authored by Bastien Montagne (mont29) on Mar 30 2021, 10:01 AM.

Tags

None

Subscribers

Jeroen Bakker (jbakker)

Nathan Craddock (natecraddock)

RedMser (RedMser)

Details

Reviewers

Julian Eisel (Severin)

Summary

This is a minimal, information-only view currently, listing by default
all the override data-blocks, with their user-edited override
properties.

System-generated overrides (like the overrides of pointers to other
override data-blocks) can be shown through a filter option.

Finally, potential info or warning messages from (auto-)resync propcess
are also shown, as an icon + tooltip next to the affected items.

NOTE: there are other tweaks and fixes in the outliner view in this patch (most notable one being the 'compact icon row' being extended to more tree item types). Those will be committed separately.

Diff Detail

Repository

Branch

override-outliner-view

Build Status

Buildable 13813
Build 13813: arc lint + arc unit

Event Timeline

Bastien Montagne (mont29) requested review of this revision.Mar 30 2021, 10:01 AM

Bastien Montagne (mont29) created this revision.

Harbormaster completed remote builds in B13813: Diff 35758.Mar 30 2021, 10:01 AM

Minor cleanup.

Harbormaster completed remote builds in B13814: Diff 35759.Mar 30 2021, 10:08 AM

RedMser (RedMser) added a subscriber: RedMser (RedMser).Mar 31 2021, 12:16 AM

Just a few minor comments, seems pretty much fine.

source/blender/editors/space_outliner/outliner_draw.c
1788–1789	Meh, we keep repeating this same check, should be moved into a function. But I can do that after this patch is in.
1854	Why call this `parent_has_warnings`? This doesn't seem to check the parent. Maybe `any_has_warnings` or `any_item_has_warnings`? And maybe `has_warnings` should become `item_has_warnings`, to be clear that this only relates to the current item.
3009–3022	I asked Nathan why only few types used the icon merging before. I don't see a reason myself.
source/blender/makesrna/intern/rna_space.c
3406	Description could be improved. "Display data-blocks with library overrides and list their overridden values"?
3602	Instead of "by Blender" I'd say "automatically". Maybe we could also mention an example of when this is done? So my proposal: "For libraries with overrides created, show the overridden values that are defined/controlled automatically (e.g. to make users of an overridden data-block point to the override data, not the original data)"

Nathan Craddock (natecraddock) added a subscriber: Nathan Craddock (natecraddock).Apr 7 2021, 2:58 AM

Nathan Craddock (natecraddock) added inline comments.

source/blender/editors/space_outliner/outliner_draw.c
3009–3022	@Julian Eisel (Severin) I don't know either. Those types were always there from what I recall.

Updated from review, thanks.

Harbormaster completed remote builds in B13912: Diff 35932.Apr 7 2021, 11:57 AM

Bastien Montagne (mont29) added inline comments.Apr 7 2021, 11:57 AM

source/blender/editors/space_outliner/outliner_draw.c
1788–1789	Yes, would rather not add even more unrelated cleanup/refactor in this patch, it already has too many. ;)

Julian Eisel (Severin) accepted this revision.Apr 7 2021, 1:03 PM

This revision is now accepted and ready to land.Apr 7 2021, 1:03 PM

Bastien Montagne (mont29) mentioned this in rB8b68a7587237: LibOverride: Add a new 'leftover' flag to ID..Apr 8 2021, 11:48 AM

Bastien Montagne (mont29) mentioned this in rB92dfc8f2673e: Outliner: regroup more type of entries under a single icon..

Bastien Montagne (mont29) mentioned this in rBe1ae5bd45fd0: LibOverride: Add a dedicated view in the Outliner..

Committed as listed above.

Revision Contents
Changeset List

Path

Size

release/

scripts/

startup/

bl_ui/

space_outliner.py

37 lines

source/

blender/

blenkernel/

intern/

10 lines

editors/

space_outliner/

1 line

outliner_collections.c

7 lines

outliner_draw.c

134 lines

outliner_intern.h

2 lines

outliner_sync.c

7 lines

outliner_tree.c

5 lines

outliner_utils.c

1 line

space_outliner.c

2 lines

tree/

tree_display.hh

18 lines

tree_display.cc

3 lines

tree_display_override_library.cc

204 lines

tree_element_overrides.hh

1 line

tree_element_overrides.cc

41 lines

makesdna/

5 lines

DNA_space_types.h

3 lines

makesrna/

intern/

13 lines

Diff 35758

release/scripts/startup/bl_ui/space_outliner.py

Loading...

source/blender/blenkernel/intern/lib_override.c

Loading...

source/blender/editors/space_outliner/CMakeLists.txt

Loading...

source/blender/editors/space_outliner/outliner_collections.c

Loading...

source/blender/editors/space_outliner/outliner_draw.c

Loading...

source/blender/editors/space_outliner/outliner_intern.h

Loading...

source/blender/editors/space_outliner/outliner_sync.c

Loading...

source/blender/editors/space_outliner/outliner_tree.c

Loading...

source/blender/editors/space_outliner/outliner_utils.c

Loading...

source/blender/editors/space_outliner/space_outliner.c

Loading...

source/blender/editors/space_outliner/tree/tree_display.hh

Loading...

source/blender/editors/space_outliner/tree/tree_display.cc

Loading...

source/blender/editors/space_outliner/tree/tree_display_override_library.cc

Loading...

source/blender/editors/space_outliner/tree/tree_element_overrides.hh

Loading...

source/blender/editors/space_outliner/tree/tree_element_overrides.cc

Loading...

source/blender/makesdna/DNA_ID.h

Loading...

source/blender/makesdna/DNA_space_types.h

Loading...

source/blender/makesrna/intern/rna_space.c

Loading...