Page MenuHome
Differential D10864

Fix T86947: Drag & Drop tooltip in Scene mode
ClosedPublic
Actions

Authored by Falk David (filedescriptor) on Mar 31 2021, 9:33 AM.

Details

Reviewers
Jacques Lucke (JacquesLucke)
Maniphest Tasks
T86947: Outliner: wrong tooltip for moving collections (Scenes mode)
Commits
rBd97dca510625: Fix T86947: Drag & Drop tooltip in Scene mode
Summary

The tooltip while dragging a collection in Scene mode in the Outliner
was always "Link inside Collection" even if the action performed was
different. This was because the collection_drop_init set the
from_collection always to NULL if the Outliner display mode was
currently set to Scene.
Commit that introduced this issue:
rB0f54c3a9b75be8f8db9022fb0aeb0f8d0d4f0299

The fix removes the check of the display mode and only sets the
from_collection to NULL if the ctrl (linking) key is held.

Diff Detail

Repository
rB Blender

Event Timeline

Falk David (filedescriptor) requested review of this revision.Mar 31 2021, 9:33 AM
Falk David (filedescriptor) created this revision.
Harbormaster completed remote builds in B13835: Diff 35794.Mar 31 2021, 9:33 AM
Falk David (filedescriptor) edited the summary of this revision. (Show Details)Mar 31 2021, 9:35 AM
Falk David (filedescriptor) added a reviewer: Jacques Lucke (JacquesLucke).Mar 31 2021, 9:38 AM
Jacques Lucke (JacquesLucke) accepted this revision.Mar 31 2021, 10:09 AM
This revision is now accepted and ready to land.Mar 31 2021, 10:09 AM
Closed by commit rBd97dca510625: Fix T86947: Drag & Drop tooltip in Scene mode (authored by Falk David (filedescriptor)). · Explain WhyMar 31 2021, 2:23 PM
This revision was automatically updated to reflect the committed changes.
Falk David (filedescriptor) added a commit: rBd97dca510625: Fix T86947: Drag & Drop tooltip in Scene mode.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
space_outliner/
6 lines

Diff 35803

View Options

source/blender/editors/space_outliner/outliner_dragdrop.c

Loading...