Page MenuHome
Differential D10866

Fix T86874: Wireframe Overlay Mesh Primitives Grid, Circle
AbandonedPublic
Actions

Authored by Himanshi Kalra (calra) on Mar 31 2021, 12:55 PM.

Details

Reviewers
Dalai Felinto (dfelinto)
Hans Goudey (HooglyBoogly)
Maniphest Tasks
T86874: Geometry node Plane primitive does not show wireframe in viewport
Summary

Fix for T86874
Adds a round trip from Mesh -> BMesh -> Mesh.
Added for the primtives that don't use BMesh i.e. Grid and Circle

Merge branch 'master' into grid_plane_no_wireframe

Diff Detail

Repository
rB Blender
Branch
grid_plane_no_wireframe (branched from master)
Build Status
Buildable 13839
Build 13839: arc lint + arc unit

Event Timeline

Himanshi Kalra (calra) requested review of this revision.Mar 31 2021, 12:55 PM
Himanshi Kalra (calra) created this revision.
Harbormaster completed remote builds in B13839: Diff 35798.Mar 31 2021, 12:55 PM
Himanshi Kalra (calra) retitled this revision from Fix T86078: Wireframe Overlay Mesh Primitives Grid, Circle to Fix T86874: Wireframe Overlay Mesh Primitives Grid, Circle.Mar 31 2021, 12:58 PM
Himanshi Kalra (calra) updated this revision to Diff 35799.Mar 31 2021, 1:03 PM
  • Fixing the TXXXX number in the comment
Harbormaster completed remote builds in B13840: Diff 35799.Mar 31 2021, 1:03 PM
Himanshi Kalra (calra) edited the summary of this revision. (Show Details)Mar 31 2021, 1:05 PM
Himanshi Kalra (calra) added reviewers: Dalai Felinto (dfelinto), Hans Goudey (HooglyBoogly).
Pratik Borhade (PratikPB2123) added a task: T86874: Geometry node Plane primitive does not show wireframe in viewport.Mar 31 2021, 1:15 PM
Hans Goudey (HooglyBoogly) abandoned this revision.Mar 31 2021, 4:09 PM

Thanks for looking into this @Himanshi Kalra (calra). Unfortunately this is not the solution though. Converting from mesh to bmesh and back is not a trivial operation, and should be avoided where possible.

A proper fix would likely add whatever data is added during the conversion process that's required for wireframe to work, or fix the wireframe overlay so it can work in this case.

So I'm going to close this patch, but feel free to submit another if you happen on a different solution!

Revision Contents
Changeset List

PathSize
source/
blender/
nodes/
geometry/
nodes/
13 lines
13 lines

Diff 35798

View Options

source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_circle.cc

Loading...
View Options

source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_grid.cc

Loading...