Details

Reviewers

Commits

rBfa4a35d4c4ee: Measure tool: Add support to restrict dimension to one axis

Summary

The measure tool feels a bit forgotten and lacks a lot of features that other tools have. This is a proposal to make it a bit more useful.
Looking at the code it would probably need a lot of updating with a key map and so on, so maybe this could be concidered a hack, I don't know.

Press X, Y or Z to restrict the dimension to that axis (update: now also possible to toggle between orientations like in for example the move tool):

Diff Detail

Repository: rB Blender

Event Timeline

Erik Abrahamsson (erik85) requested review of this revision.Apr 1 2021, 1:57 AM

Erik Abrahamsson (erik85) created this revision.

Erik Abrahamsson (erik85) added a project: Modeling.Apr 1 2021, 2:11 AM

Aaron Carlisle (Blendify) awarded a token.Apr 1 2021, 6:36 AM

Matej Junk (MJunk) awarded a token.Apr 1 2021, 7:51 AM

Lillya (Lillya) awarded a token.Apr 1 2021, 1:26 PM

This seems useful, some changes requested.

source/blender/editors/space_view3d/view3d_gizmo_ruler.c
109–111	use `bool restrict_axes[3];` - to avoid duplication.
397–407	This can support the current scene orientation. See: `ED_transform_calc_orientation_from_type`

This revision now requires changes to proceed.Apr 1 2021, 1:36 PM

Pieter Schiettecatte (Schiette) awarded a token.Apr 1 2021, 3:34 PM

Fran Marz (franMarz) awarded a token.Apr 1 2021, 6:41 PM

Gilberto Rodrigues (gilberto_rodrigues) awarded a token.Apr 3 2021, 4:00 AM

Ermins Ermanis (erminos) added a subscriber: Ermins Ermanis (erminos).Apr 4 2021, 2:37 AM

Pratik Borhade (PratikPB2123) awarded a token.Apr 5 2021, 3:28 PM

Changed the keys X/Y/Z to toggle between none, scene orientation and global (or local if scene is global).

Campbell Barton (campbellbarton) requested changes to this revision.Apr 7 2021, 2:53 PM

Campbell Barton (campbellbarton) added inline comments.

source/blender/editors/space_view3d/view3d_gizmo_ruler.c
103–106	Should be a separate enum, use `CONSTRAIN_AXIS_` prefix.
447–455	can be made into a for loop.
1004	This doesn't seem correct, changing from one axis to another shouldn't have to change this mode.
1006–1017	can be made into a for loop.
1019	Should include a comment for then this might happen.

This revision now requires changes to proceed.Apr 7 2021, 2:53 PM

Commented the code and tried to fix all things pointed out in the review. Also refactored the cycling code to make it clearer what is going on.

Dion Moult (Moult) awarded a token.Apr 8 2021, 12:11 AM

Dion Moult (Moult) added a subscriber: Dion Moult (Moult).

Oleg (DotBow) awarded a token.Apr 9 2021, 11:38 PM

Wovchik (microcoder) awarded a token.Apr 23 2021, 5:34 PM

Wovchik (microcoder) added a subscriber: Wovchik (microcoder).

Cian Jinks (Hobbes) added a subscriber: Cian Jinks (Hobbes).May 26 2021, 1:06 PM

Updated to work with latest master.

Germano Cavalcante (mano-wii) added a subscriber: Germano Cavalcante (mano-wii).Aug 20 2021, 2:24 PM

This is now updated again to apply on master.

Sync with master, minor changes.
Use a define as we may want to replace this with full transform (supporting each feature duplicates logic).
Avoid passing in the context.

Harbormaster completed remote builds in B16708: Diff 41250.Aug 31 2021, 9:16 AM

Campbell Barton (campbellbarton) accepted this revision.Aug 31 2021, 9:16 AM

This revision is now accepted and ready to land.Aug 31 2021, 9:16 AM

Thanks, committed rBfa4a35d4c4eea7cd0c4a9a8bf448afd27c273695

Campbell Barton (campbellbarton) added a commit: rBfa4a35d4c4ee: Measure tool: Add support to restrict dimension to one axis.Aug 31 2021, 9:23 AM

Vitalii Vlasov (Fracture128) awarded a token.Aug 31 2021, 10:54 AM

Alexey Adamitsky (AlexeyAdamitsky) awarded a token.Sep 7 2021, 7:30 AM