Differential D10878

Fix T86874: Wireframe Overlay Mesh Primitives Grid, Circle. Add ME_EDGEDRAW, ME_EDGERENDER edge flags
ClosedPublic
Actions

Authored by Kris (Metricity) on Apr 2 2021, 1:56 AM.

Details

Reviewers

Hans Goudey (HooglyBoogly)

Maniphest Tasks

T86874: Geometry node Plane primitive does not show wireframe in viewport

Commits

rB3fcac263622b: Fix T86874: Wireframe not drawing for geometry node mesh primitives

Summary

Fix T86874: Wireframe Overlay Mesh Primitives Grid, Circle. Add ME_EDGEDRAW, ME_EDGERENDER edge flags

Set flags on the inside edges for grid and circle triangle fan (mesh primitive nodes) so they are visible and selectable.

Diff Detail

Repository: rB Blender

Event Timeline

Kris (Metricity) requested review of this revision.Apr 2 2021, 1:56 AM

Kris (Metricity) created this revision.

No code changes, added more context to the diff

Nice, thanks! Seems these flags are actually added in many places, so this is quite reasonable.

It's a shame there are no comments on their definitions, would have saved us all some time!

This revision is now accepted and ready to land.Apr 2 2021, 5:53 AM

@Kris (Metricity) Hey, thanks for the patch. You mentioned that you compared the flags of the edges of Mesh and BMesh and found out that it was not set in Mesh.
I was curious to know how did you figure it out? (You used a Debugger placed breakpoints at both places and ..compared side by side?)

I tried to follow your steps and reached there. But then I thought I wouldn't have figured it out myself for a long time.
I would be glad if you could share your thought process.
We could discuss it on blender.chat as well.

Thanks!

Closed by commit rB3fcac263622b: Fix T86874: Wireframe not drawing for geometry node mesh primitives (authored by Kris Rasmussen (kris), committed by Dalai Felinto (dfelinto)). · Explain WhyApr 2 2021, 10:45 AM

This revision was automatically updated to reflect the committed changes.

Dalai Felinto (dfelinto) added a commit: rB3fcac263622b: Fix T86874: Wireframe not drawing for geometry node mesh primitives.

Thanks for the patch. Committed on rB3fcac263622b25648601613d214044f8f2e49c1a.

Yes @Himanshi Kalra (calra) I did do exactly what you mentioned. I placed a breakpoint on the return and viewed mesh in Watch 1 and result in Watch 2 (Visual Studio). This only showed data for the first edge but luckily that was different anyway. I then played with a natvis config so I could view all the edge data in the debugger.

Jesse Yurkovich (deadpin) mentioned this in D10730: Geometry Nodes: Greatly improve speed of some mesh primitives.Apr 6 2021, 9:36 PM