Page MenuHome
Differential D10880

Fix T86889: Rotation with top plane view glitches
ClosedPublic
Actions

Authored by Germano Cavalcante (mano-wii) on Apr 2 2021, 7:44 PM.

Details

Reviewers
Campbell Barton (campbellbarton)
Commits
rB490801ba1d20: Fix T86889: Rotation with top plane view glitches
Summary

The InputAngle function uses a flawed algorithm to correct a precision issue.

This patch refactor the logic of the function by using BLI utilities.

Diff Detail

Repository
rB Blender
Branch
master
Build Status
Buildable 13868
Build 13868: arc lint + arc unit

Event Timeline

Germano Cavalcante (mano-wii) requested review of this revision.Apr 2 2021, 7:44 PM
Germano Cavalcante (mano-wii) created this revision.
Harbormaster completed remote builds in B13868: Diff 35857.Apr 2 2021, 7:44 PM
Germano Cavalcante (mano-wii) updated this revision to Diff 35869.Apr 3 2021, 5:20 PM
  • Fix BLI_ASSERT_UNIT_V2_DB in Release build
Harbormaster completed remote builds in B13873: Diff 35869.Apr 3 2021, 5:20 PM
Campbell Barton (campbellbarton) accepted this revision.Apr 6 2021, 7:38 AM
This revision is now accepted and ready to land.Apr 6 2021, 7:38 AM
Campbell Barton (campbellbarton) added inline comments.Apr 6 2021, 7:40 AM
source/blender/blenlib/BLI_math_base.h
114

Suggest keep both saasin, add saasin_db

Campbell Barton (campbellbarton) requested changes to this revision.Apr 6 2021, 9:51 AM

Note that using double doesn't seem necessary, using your code without double precision fixes the bug: P2057.
As far as I can see the this smaller patch could be committed as a fix instead.

source/blender/blenlib/intern/math_vector_inline.c
1191

unit_length isn't used.

This revision now requires changes to proceed.Apr 6 2021, 9:51 AM
Germano Cavalcante (mano-wii) updated this revision to Diff 35899.Apr 6 2021, 3:13 PM
  • Use float precision

Good to see that the result is also fixed with float.
In fact, I tested this new patch a lot and I couldn't notice a change in the rotation position due to some lack of precision.

Harbormaster completed remote builds in B13889: Diff 35899.Apr 6 2021, 3:13 PM
Germano Cavalcante (mano-wii) retitled this revision from Add double utilities to BLI and refactor 'InputAngle' of transform_input.c to Fix T86889: Rotation with top plane view glitches.Apr 6 2021, 3:18 PM
Germano Cavalcante (mano-wii) edited the summary of this revision. (Show Details)
Campbell Barton (campbellbarton) accepted this revision.Apr 6 2021, 3:33 PM
This revision is now accepted and ready to land.Apr 6 2021, 3:33 PM
Closed by commit rB490801ba1d20: Fix T86889: Rotation with top plane view glitches (authored by Germano Cavalcante (mano-wii)). · Explain WhyApr 6 2021, 3:42 PM
This revision was automatically updated to reflect the committed changes.
Germano Cavalcante (mano-wii) added a commit: rB490801ba1d20: Fix T86889: Rotation with top plane view glitches.

Revision Contents
Changeset List

PathSize
source/
blender/
blenlib/
10 lines
10 lines
intern/
18 lines
43 lines
58 lines
editors/
transform/
55 lines

Diff 35857

View Options

source/blender/blenlib/BLI_math_base.h

Loading...
View Options

source/blender/blenlib/BLI_math_vector.h

Loading...
View Options

source/blender/blenlib/intern/math_base_inline.c

Loading...
View Options

source/blender/blenlib/intern/math_vector.c

Loading...
View Options

source/blender/blenlib/intern/math_vector_inline.c

Loading...
View Options

source/blender/editors/transform/transform_input.c

Loading...