With this patch, users can define custom tooltips for the exposed properties of their Geometry Nodes Groups.
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- tooltips_for_modifier_nodes (branched from master)
- Build Status
Buildable 13871 Build 13871: arc lint + arc unit
Event Timeline
Comment Actions
@Dalai Felinto (dfelinto) Should we call the property description instead of tooltip?
Comment Actions
The functionality is good but unfortunately it's quite a hacky solution-- mainly the process of changing buttons in the uiBlock directly in the set_tooltip function.
In other words, this sort of thing is what makes the interface code convoluted already, and we strive not to add more of it.
A proper solution would probably copy the description to the IDProperty when it gets created based on the socket in MOD_nodes.cc
| source/blender/modifiers/intern/MOD_nodes.cc | ||
|---|---|---|
| 79 | It's quite important not to do this. The stuff in interface_intern should not be depended on by code outside of the interface directory. These boundaries exist for important reasons-- otherwise changing the UI code implementation becomes prohibitively hard, etc. Generally intern headers should only be included inside their relevant directory. | |
Comment Actions
Yes, this is nicer! Quite close I think
| source/blender/editors/space_node/node_buttons.c | ||
|---|---|---|
| 159 | Since this only has an effect in node modifier panels, I think it would be best to only display it for geometry node groups for now. | |
| source/blender/makesrna/intern/rna_nodetree.c | ||
| 9668 | Isn't custom redundant here? I would call the RNA property "description", even if we refer to it by "Tooltip" in the UI, since it's more consistent. | |
| 9668–9671 | I'd put this a bit lower. Maybe after identifier, just because it's relatively less important. | |
| source/blender/modifiers/intern/MOD_nodes.cc | ||
| 79 | Now you can remove this ; ) | |
Comment Actions
Looks good! The commit should mention that it doesn't display in the node editor at all, but that it's a long term goal to make that work.
| source/blender/editors/space_node/node_buttons.c | ||
|---|---|---|
| 161 | Line length. I suggest shortening it a little with since it's only used in | |