Page MenuHome
Differential D10902

Fix T87157: GPencil subdivide last segment
ClosedPublic
Actions

Authored by Falk David (filedescriptor) on Apr 6 2021, 4:15 PM.

Details

Reviewers
Antonio Vazquez (antoniov)
Maniphest Tasks
T87157: can't subdivide square in grease pencil one side
Commits
rB09d7d88cc42a: Fix T87157: GPencil subdivide last segment
Summary

Previously it was not possible to subdivide the last segment of a cyclic
stroke.

The fix makes sure that the correct number of new points is calculated
correctly and adds the new points to the last segment.

Diff Detail

Repository
rB Blender
Branch
T87157 (branched from master)
Build Status
Buildable 13891
Build 13891: arc lint + arc unit

Event Timeline

Falk David (filedescriptor) requested review of this revision.Apr 6 2021, 4:15 PM
Falk David (filedescriptor) created this revision.
Harbormaster completed remote builds in B13891: Diff 35902.Apr 6 2021, 4:15 PM
Antonio Vazquez (antoniov) accepted this revision.Apr 6 2021, 4:20 PM

LGTM

Good to add this feature.

This revision is now accepted and ready to land.Apr 6 2021, 4:20 PM
Falk David (filedescriptor) updated this revision to Diff 35909.Apr 6 2021, 5:31 PM

Fix memory leaks and check selection.

Harbormaster completed remote builds in B13898: Diff 35909.Apr 6 2021, 5:31 PM
Closed by commit rB09d7d88cc42a: Fix T87157: GPencil subdivide last segment (authored by Falk David (filedescriptor)). · Explain WhyApr 11 2021, 10:11 PM
This revision was automatically updated to reflect the committed changes.
Falk David (filedescriptor) added a commit: rB09d7d88cc42a: Fix T87157: GPencil subdivide last segment.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
gpencil/
44 lines

Diff 35902

View Options

source/blender/editors/gpencil/gpencil_edit.c

Loading...