Page MenuHome
Differential D10903

Fix T87236: crash reading file with grease pencil palettes
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Apr 6 2021, 4:37 PM.

Details

Reviewers
Jacques Lucke (JacquesLucke)
Antonio Vazquez (antoniov)
Maniphest Tasks
T87236: Crash on opening specific file
Commits
rBb61b34a5d279: Fix T87236: crash reading file with grease pencil palettes
Summary

Caused by typo in rB76689e851700: Cleanup: use LISTBASE_FOREACH in readfile.c.

Since Palettes and bGPDpalette are not the same size, this would not
only cause a crash in versioning code, but could only go downhill from
here on.

Diff Detail

Repository
rB Blender
Branch
T87236 (branched from master)
Build Status
Buildable 13897
Build 13897: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Apr 6 2021, 4:37 PM
Philipp Oeser (lichtwerk) created this revision.
Harbormaster completed remote builds in B13897: Diff 35908.Apr 6 2021, 4:38 PM
Philipp Oeser (lichtwerk) added projects: Core, Grease Pencil.Apr 6 2021, 4:38 PM
Antonio Vazquez (antoniov) accepted this revision.Apr 6 2021, 4:39 PM

LGTM... great to catch this typo error.

This revision is now accepted and ready to land.Apr 6 2021, 4:39 PM
Jacques Lucke (JacquesLucke) accepted this revision.Apr 6 2021, 4:40 PM

Uh that's bad, good catch, thanks.

Closed by commit rBb61b34a5d279: Fix T87236: crash reading file with grease pencil palettes (authored by Philipp Oeser (lichtwerk)). · Explain WhyApr 6 2021, 5:35 PM
This revision was automatically updated to reflect the committed changes.
Philipp Oeser (lichtwerk) added a commit: rBb61b34a5d279: Fix T87236: crash reading file with grease pencil palettes.

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
intern/
2 lines

Diff 35908

View Options

source/blender/blenkernel/intern/gpencil.c

Loading...