Page MenuHome
Differential D10917

Fix T86762: Inconsistent show of result of modifier Screw in edit mode
ClosedPublic
Actions

Authored by Germano Cavalcante (mano-wii) on Apr 7 2021, 9:03 PM.

Details

Reviewers
Clément Foucault (fclem)
Maniphest Tasks
T86762: Inconsistent show of result of modifier Screw in edit mode
Commits
rB3d6798962c20: Fix T86762: Inconsistent show of result of modifier Screw in edit mode
Summary

To check if an "is_mesh_verts_only" mesh, the overlay engine checks if the
mesh has no "totedge" and has "totvert".

However, sometimes this engine can check the wrong mesh since editmesh
works on embm->mesh_eval_final.

This causes this:

This patch proposes to read the mesh members actually used for the draw
engine.

Ref T86762

Diff Detail

Repository
rB Blender

Event Timeline

Germano Cavalcante (mano-wii) requested review of this revision.Apr 7 2021, 9:03 PM
Germano Cavalcante (mano-wii) created this revision.
Harbormaster completed remote builds in B13930: Diff 35959.Apr 7 2021, 9:03 PM
Clément Foucault (fclem) accepted this revision.Apr 8 2021, 5:32 PM
This revision is now accepted and ready to land.Apr 8 2021, 5:32 PM
Closed by commit rB3d6798962c20: Fix T86762: Inconsistent show of result of modifier Screw in edit mode (authored by Germano Cavalcante (mano-wii)). · Explain WhyApr 8 2021, 6:09 PM
This revision was automatically updated to reflect the committed changes.
Germano Cavalcante (mano-wii) added a commit: rB3d6798962c20: Fix T86762: Inconsistent show of result of modifier Screw in edit mode.

Revision Contents
Changeset List

PathSize
source/
blender/
draw/
engines/
overlay/
29 lines

Diff 35997

View Options

source/blender/draw/engines/overlay/overlay_wireframe.c

Loading...