Page MenuHome
Differential D10920

Experimental patch to split evaluated meshes out of edit-mesh
AbandonedPublic
Actions

Authored by Campbell Barton (campbellbarton) on Apr 8 2021, 2:42 AM.

Details

Reviewers
None
Summary

To properly support multiple objects in edit-mode, we will have to move evaluation data data out of the shared EditMesh structure. See T85974: Edit-mode undo/redo causes assertion.

Note that to properly support this we'll have to remove EditMeshData isn't thread save.

This patch could be extended to do this, in the short term it's simplest to disallow multiple objects sharing data to be in edit-mode at the same time.

Diff Detail

Repository
rB Blender
Branch
TEMP-T86767-FIX (branched from master)
Build Status
Buildable 13944
Build 13944: arc lint + arc unit

Event Timeline

Campbell Barton (campbellbarton) requested review of this revision.Apr 8 2021, 2:42 AM
Campbell Barton (campbellbarton) created this revision.
Harbormaster completed remote builds in B13940: Diff 35971.Apr 8 2021, 2:42 AM
Campbell Barton (campbellbarton) updated this revision to Diff 35974.Apr 8 2021, 5:00 AM
  • Move evaluation data into EditMeshEval struct

    Do this since EditMeshData is often on the final/cage meshes but not the 'ob_eval->data' where which uses this struct.
Harbormaster completed remote builds in B13942: Diff 35974.Apr 8 2021, 5:00 AM
Campbell Barton (campbellbarton) updated this revision to Diff 35976.EditedApr 8 2021, 5:20 AM

Correct comment.

Harbormaster completed remote builds in B13944: Diff 35976.Apr 8 2021, 5:20 AM
Campbell Barton (campbellbarton) abandoned this revision.Apr 8 2021, 5:31 AM
Campbell Barton (campbellbarton) edited the summary of this revision. (Show Details)
Campbell Barton (campbellbarton) mentioned this in rBaa6f0f3d1fdd: Depsgraph: remove mesh edit-mode pointer duplication.May 21 2021, 8:24 AM

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
11 lines
1 line
intern/
36 lines
45 lines
5 lines
16 lines
6 lines
3 lines
6 lines
1 line
depsgraph/
intern/
eval/
5 lines
draw/
engines/
overlay/
3 lines
6 lines
select/
2 lines
intern/
20 lines
19 lines
5 lines
editors/
mesh/
5 lines
space_view3d/
5 lines
transform/
34 lines
util/
13 lines
makesdna/
21 lines

Diff 35976

View Options

source/blender/blenkernel/BKE_editmesh.h

Loading...
View Options

source/blender/blenkernel/BKE_mesh_runtime.h

Loading...
View Options

source/blender/blenkernel/intern/DerivedMesh.cc

Loading...
View Options

source/blender/blenkernel/intern/editmesh.c

Loading...
View Options

source/blender/blenkernel/intern/mesh_convert.c

Loading...
View Options

source/blender/blenkernel/intern/mesh_runtime.c

Loading...
View Options

source/blender/blenkernel/intern/modifier.c

Loading...
View Options

source/blender/blenkernel/intern/object.c

Loading...
View Options

source/blender/blenkernel/intern/object_dupli.cc

Loading...
View Options

source/blender/blenkernel/intern/object_update.c

Loading...
View Options

source/blender/depsgraph/intern/eval/deg_eval_copy_on_write.cc

Loading...
View Options

source/blender/draw/engines/overlay/overlay_edit_mesh.c

Loading...
View Options

source/blender/draw/engines/overlay/overlay_wireframe.c

Loading...
View Options

source/blender/draw/engines/select/select_draw_utils.c

Loading...
View Options

source/blender/draw/intern/draw_cache_extract_mesh.c

Loading...
View Options

source/blender/draw/intern/draw_cache_impl_mesh.c

Loading...
View Options

source/blender/draw/intern/draw_manager.c

Loading...
View Options

source/blender/editors/mesh/editmesh_utils.c

Loading...
View Options

source/blender/editors/space_view3d/view3d_snap.c

Loading...
View Options

source/blender/editors/transform/transform_snap_object.c

Loading...
View Options

source/blender/editors/util/ed_transverts.c

Loading...
View Options

source/blender/makesdna/DNA_mesh_types.h

Loading...