Fix T87150: bad points appearance in orthographic view
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Apr 8 2021, 5:21 PM.

Details

Reviewers

Clément Foucault (fclem)
Jacques Lucke (JacquesLucke)

Maniphest Tasks

T87150: Points’ appearance in orthographic mode

Commits

rB21102395472d: Fix T87150: bad points appearance in orthographic view

Summary

Points are drawn as half octahedron (aligned to the camera).
Getting the appropriate matrix for facing the camera would fail in in
orthographic view, points were not facing the camera (revealing their
missing other half octahedron)

Diff Detail

Repository: rB Blender

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Apr 8 2021, 5:21 PM

Philipp Oeser (lichtwerk) created this revision.

Harbormaster completed remote builds in B13952: Diff 35991.Apr 8 2021, 5:21 PM

Philipp Oeser (lichtwerk) added projects: EEVEE & Viewport, Nodes & Physics.Apr 8 2021, 5:22 PM

Use viewCameraVec(p) instead.

use premade 'cameraVec'

Harbormaster completed remote builds in B13953: Diff 35994.Apr 8 2021, 5:55 PM

In D10923#278639, @Clément Foucault (fclem) wrote:

Use viewCameraVec(p) instead.

cameraVec I guess?

Clément Foucault (fclem) accepted this revision.Apr 8 2021, 6:54 PM

This revision is now accepted and ready to land.Apr 8 2021, 6:54 PM

Vyacheslav (hitrpr) awarded a token.Apr 8 2021, 9:27 PM

Closed by commit rB21102395472d: Fix T87150: bad points appearance in orthographic view (authored by Philipp Oeser (lichtwerk)). · Explain WhyApr 9 2021, 9:18 AM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rB21102395472d: Fix T87150: bad points appearance in orthographic view.

Revision Contents
Changeset List

Path

Size

source/

blender/

draw/

intern/

shaders/

common_pointcloud_lib.glsl

2 lines

Diff 36012

View Options

source/blender/draw/intern/shaders/common_pointcloud_lib.glsl

Fix T87150: bad points appearance in orthographic viewClosedPublicActions