Fix T87355: Crash using menu search from the top bar
AbandonedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on Apr 9 2021, 9:31 PM.

Details

Reviewers

Campbell Barton (campbellbarton)

Maniphest Tasks

T87355: Crash using menu search from the top bar

Summary

Though I'm not sure this is the proper solution, it solves the crash and
doesn't cause any other problems from what I can tell. AFAIK it may be
reasonable that this is called with a null area, but maybe not.

Diff Detail

Repository

rB Blender

Branch

fix-menu-search-crash (branched from master)

Build Status

Buildable 13977
Build 13977: arc lint + arc unit

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Apr 9 2021, 9:31 PM

Hans Goudey (HooglyBoogly) created this revision.

Harbormaster completed remote builds in B13977: Diff 36035.Apr 9 2021, 9:31 PM

Hans Goudey (HooglyBoogly) added a reviewer: Campbell Barton (campbellbarton).Apr 9 2021, 9:31 PM

Hans Goudey (HooglyBoogly) added a task: T87355: Crash using menu search from the top bar.

Thanks for looking into this.
Committed alternate fix rB947ba0d27bf58b3efdae9617cb87a3dba0dbc0dd,

I'd rather not have itemf types have to check the ptr.data values are valid.

Revision Contents
Changeset List

Path

Size

source/

blender/

makesrna/

intern/

rna_screen.c

2 lines

Diff 36035

View Options

source/blender/makesrna/intern/rna_screen.c

Fix T87355: Crash using menu search from the top barAbandonedPublicActions