Page MenuHome
Differential D10934

Fix T87356: Bad offset for node link in multi-input socket
AbandonedPublic
Actions

Authored by Fabian Schempp (fabian_schempp) on Apr 10 2021, 11:02 AM.

Details

Reviewers
Hans Goudey (HooglyBoogly)
Maniphest Tasks
T87356: Bad offset for node link in multi-input socket after disconnecting
Summary

The problem occured because last_node_hovered_while_dragging_a_link was not set on node_link_init.

Diff Detail

Repository
rB Blender
Branch
fix_multi_input_socket_crash_bug_T87358 (branched from master)
Build Status
Buildable 13979
Build 13979: arc lint + arc unit

Event Timeline

Fabian Schempp (fabian_schempp) requested review of this revision.Apr 10 2021, 11:02 AM
Fabian Schempp (fabian_schempp) created this revision.
Harbormaster completed remote builds in B13979: Diff 36038.Apr 10 2021, 11:02 AM
Fabian Schempp (fabian_schempp) retitled this revision from Fixes T87356 last_node_hovered_while_dragging_a_link was not set on node_link_init. to Fixes T87356.Apr 10 2021, 11:03 AM
Fabian Schempp (fabian_schempp) edited the summary of this revision. (Show Details)
Fabian Schempp (fabian_schempp) added a reviewer: Hans Goudey (HooglyBoogly).
Fabian Schempp (fabian_schempp) added projects: Nodes & Physics, Geometry Nodes.
Fabian Schempp (fabian_schempp) added a task: T87356: Bad offset for node link in multi-input socket after disconnecting.
Hans Goudey (HooglyBoogly) retitled this revision from Fixes T87356 to Fix T87356: Bad offset for link in multi-input socket after disconnecting.Apr 10 2021, 11:55 PM
Hans Goudey (HooglyBoogly) retitled this revision from Fix T87356: Bad offset for link in multi-input socket after disconnecting to Fix T87356: Bad offset for node link in multi-input socket.
Hans Goudey (HooglyBoogly) added a comment.Apr 11 2021, 12:08 AM

It's much better, but I still see a flicker on the top position for one redraw before the top link moved back to the center. I'd hope it would be possible to fix that.

Fabian Schempp (fabian_schempp) abandoned this revision.Apr 11 2021, 2:46 AM

Joint this patch into https://developer.blender.org/D10940 for convenience.

Fabian Schempp (fabian_schempp) added a comment.Apr 11 2021, 2:47 AM
In D10934#279047, @Hans Goudey (HooglyBoogly) wrote:

It's much better, but I still see a flicker on the top position for one redraw before the top link moved back to the center. I'd hope it would be possible to fix that.

Should be possible to solve this.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
space_node/
2 lines

Diff 36038

View Options

source/blender/editors/space_node/node_relationships.c

Loading...