Fix T87348: Convert vertex colors to linear color space.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Apr 12 2021, 8:54 AM.

Details

Reviewers

Simon Thommes (simonthommes)
Jeroen Bakker (jbakker)

Maniphest Tasks

T87348: Geometry Nodes don't convert vertex colors accurately when data is realized

Commits

rB175c1382da4d: Fix T87348: convert vertex colors to linear color space

Summary

This is not really my area of expertise, but it seems like vertex colors are stored in srgb color space, while other colors are in linear color space. This patch changes it so that when a vertex color attribute is accessed, the color space conversion happens automatically.

Cycles seems to be doing the same conversion in triangle_attribute_float4.

Diff Detail

Repository: rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Apr 12 2021, 8:54 AM

Jacques Lucke (JacquesLucke) created this revision.

Harbormaster completed remote builds in B14001: Diff 36071.Apr 12 2021, 8:54 AM

Jacques Lucke (JacquesLucke) added a task: T87348: Geometry Nodes don't convert vertex colors accurately when data is realized.Apr 12 2021, 8:55 AM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Apr 12 2021, 8:58 AM

Jacques Lucke (JacquesLucke) added reviewers: Simon Thommes (simonthommes), Jeroen Bakker (jbakker).

Seems fine.

Would it be an idea to add a role to the Color4f/Color3f classes so the color space becomes more obvious.
If we keep mentioning that colors are just 3 floats, or 4 floats we will always make mistakes.

Color4f<Space::SceneRef, Alpha::Associated> and never allow Color4f or Color3f :-)

This revision is now accepted and ready to land.Apr 12 2021, 9:14 AM

Thanks for the review.
That's an interesting idea. Feel free to give it a try. :)

Closed by commit rB175c1382da4d: Fix T87348: convert vertex colors to linear color space (authored by Jacques Lucke (JacquesLucke)). · Explain WhyApr 12 2021, 9:19 AM

This revision was automatically updated to reflect the committed changes.

Jacques Lucke (JacquesLucke) added a commit: rB175c1382da4d: Fix T87348: convert vertex colors to linear color space.

Evan Wilson (EAW) awarded a token.Jul 30 2021, 12:30 AM

Alexey (lexpartizan) mentioned this in T91759: The colors of the vertices do not correspond to the values in which I paint them with vertex paint..Sep 27 2021, 10:19 PM