Paths

Table of Contentst

Differential D10967

Fix T78803: Bad widget drawing with the R600g driver
ClosedPublic
Actions

Authored by Omar Emara (OmarSquircleArt) on Apr 13 2021, 2:53 PM.

Tags

None

Subscribers

None

Details

Reviewers

Clément Foucault (fclem)
Sergey Sharybin (sergey)

Commits

rBd63b72e9f930: Fix T78803: Bad widget drawing with the R600g driver

Summary

The SB back-end optimizer for the mesa R600g driver corrupts the vertex
shader for widget drawing. This will not be fixed upstream because SB is
getting replaced as part of the new NIR path. This was thought to be an
issue with instancing and an attempted fix was submitted in D8374, but
it did not fix the issue.

This patch reimplements the array look-up part of the code using switch case as
a workaround and removes the old workaround implemented as part of D8374.

Diff Detail

Repository: rB Blender

Event Timeline

Omar Emara (OmarSquircleArt) requested review of this revision.Apr 13 2021, 2:53 PM

Omar Emara (OmarSquircleArt) created this revision.

Harbormaster completed remote builds in B14035: Diff 36125.Apr 13 2021, 2:53 PM

To be fair, maybe rewritting this with if/else's or a switch is better for readability and compiler issues. Can you give it a try?

@Clément Foucault (fclem) Switch case seems to work. Should I update the patch with switch case?

Please do !

Use switch case instead.

Harbormaster completed remote builds in B14042: Diff 36133.Apr 13 2021, 6:04 PM

Missing default case but this can be fixed before commiting.

This revision is now accepted and ready to land.Apr 13 2021, 6:57 PM

@Clément Foucault (fclem) Do we need a default case here? What should it do?

I mean for the sake of completeness and to avoid undefined behavior if anything goes wrong. Put the default case on top of case 0:

Closed by commit rBd63b72e9f930: Fix T78803: Bad widget drawing with the R600g driver (authored by Omar Emara (OmarSquircleArt)). · Explain WhyApr 13 2021, 10:33 PM

This revision was automatically updated to reflect the committed changes.

Omar Emara (OmarSquircleArt) added a commit: rBd63b72e9f930: Fix T78803: Bad widget drawing with the R600g driver.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

interface/

interface_widgets.c

6 lines

gpu/

shaders/

gpu_shader_2D_widget_base_vert.glsl

26 lines

Diff 36150

source/blender/editors/interface/interface_widgets.c

Loading...

source/blender/gpu/shaders/gpu_shader_2D_widget_base_vert.glsl

Loading...