Page MenuHome

Revert D10835: Removal of Lock Camera Gizmo Button
ClosedPublic

Authored by Harley Acheson (harley) on Apr 13 2021, 4:53 PM.

Details

Summary

There have been objections raised by @Julian Eisel (Severin) , @Pablo Vazquez (pablovazquez) and @Dalai Felinto (dfelinto) so this patch reverts gizmo button to lock camera to view. We can always think about this again for 3.0

Diff Detail

Repository
rB Blender

Event Timeline

Harley Acheson (harley) requested review of this revision.Apr 13 2021, 4:53 PM
Harley Acheson (harley) created this revision.
Julian Eisel (Severin) accepted this revision.EditedApr 13 2021, 7:28 PM

The decision was made to revert the addition for the 2.93 release, so accepting this. I know that many people like this addition and it would be great if we could look into this together again for the 3.0 release.

One reason to revert it is simply the process: We should aim for the highest possible standards; for non-trivial changes (which is a very blurry line, granted), we should make sure the entire UI module supports it and that it indeed follows high design standards. And currently that needs to be confirmed on a product design level by Ton.

The following design issues were identified:

  • What is the reason for the change? Discoverability? Convenience? Is it more of an indicator? It still seems uncertain. This is a red flag for good design, we should never do changes without exactly knowing why they are needed and what they improve.
  • The icon is too small and doesn't follow the style of others.
  • It behaves like a setting, unlike the other buttons there. The perspective toggle is already a stretch. If we need to make multiple exceptions, there's probably need to rethink the design.
  • It makes the UI flicker when toggling camera view.
  • What is the rule for what goes there and what not? We could put a whole bunch of settings in that corner, why this specific one?

Again, it would be great to look into a better solution, one that we can all get behind. There are plans for a 3.0 design workshop for such topics.

(Also: When committing, please make sure to mention the reverted commit @Harley Acheson (harley), not just the patch.)

This revision is now accepted and ready to land.Apr 13 2021, 7:28 PM

Also please note that this isn't just a decision by me, to a degree I'm the messenger here. I do agree with the remarks though.

There's a conflict between doing many gradual changes with small quality of life improvements and only doing changes that are very well reasoned and fleshed out. I find it very difficult to decide where I stand, I'm honestly as torn as you can be. We'll have to figure out what works best long term and what we want I guess. Meanwhile I hope nobody takes this conflict personal and that we keep getting along well.