Page MenuHome
Differential D10969

Fix T87171: Update multi input socket indices
ClosedPublic
Actions

Authored by Wannes Malfait (Wannes) on Apr 13 2021, 5:35 PM.

Details

Reviewers
Fabian Schempp (fabian_schempp)
Maniphest Tasks
T87419: Incorrect link order after inserting node before multi-input-socket.
T87171: Splicing a Join Geometry node will adopt the multi-input connection position from the following socket
Commits
rB4cf3010714e9: Fix T87171: Update multi input socket indices
Summary

When inserting a node on top of a link, the multi input socket
indices weren't updated. This fixes that and keeps the relative
order of the links the same.

Before

After

Diff Detail

Repository
rB Blender
Branch
multi_input_bug (branched from master)
Build Status
Buildable 14041
Build 14041: arc lint + arc unit

Event Timeline

Wannes Malfait (Wannes) requested review of this revision.Apr 13 2021, 5:35 PM
Wannes Malfait (Wannes) created this revision.
Harbormaster completed remote builds in B14041: Diff 36132.Apr 13 2021, 5:35 PM
Wannes Malfait (Wannes) edited the summary of this revision. (Show Details)Apr 13 2021, 5:39 PM
Wannes Malfait (Wannes) added projects: Geometry Nodes, Nodes & Physics.
Wannes Malfait (Wannes) added a task: T87171: Splicing a Join Geometry node will adopt the multi-input connection position from the following socket.
Wannes Malfait (Wannes) added a task: T87419: Incorrect link order after inserting node before multi-input-socket..Apr 13 2021, 5:42 PM
Pratik Borhade (PratikPB2123) added a reviewer: Geometry Nodes.Apr 14 2021, 3:12 AM
Hans Goudey (HooglyBoogly) edited reviewers, added: Fabian Schempp (fabian_schempp); removed: Geometry Nodes.Apr 14 2021, 6:40 AM
Hans Goudey (HooglyBoogly) added a subscriber: Hans Goudey (HooglyBoogly).

If Fabian thinks this makes sense, someone can go ahead and commit this. Thanks for the patch.

Fabian Schempp (fabian_schempp) accepted this revision.Apr 15 2021, 8:26 AM
This revision is now accepted and ready to land.Apr 15 2021, 8:26 AM
Closed by commit rB4cf3010714e9: Fix T87171: Update multi input socket indices (authored by Fabian Schempp (fabian_schempp)). · Explain WhyApr 15 2021, 11:39 AM
This revision was automatically updated to reflect the committed changes.
Fabian Schempp (fabian_schempp) added a commit: rB4cf3010714e9: Fix T87171: Update multi input socket indices.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
space_node/
9 lines

Diff 36132

View Options

source/blender/editors/space_node/node_relationships.c

Loading...