Page MenuHome
Differential D10992

Geometry Nodes: Add Shader Curve Nodes
ClosedPublic
Actions

Authored by Charlie Jolly (charlie) on Apr 16 2021, 2:58 PM.

Details

Reviewers
Jacques Lucke (JacquesLucke)
Group Reviewers
Geometry Nodes
Commits
rB8cd506639a78: Geometry Nodes: Add Shader Curve Nodes
Summary

Convert curve vec and curve rgb shader nodes to geometry nodes, based on node_shader_valToRgb.cc implementation.

Diff Detail

Repository
rB Blender
Branch
master
Build Status
Buildable 14725
Build 14725: arc lint + arc unit

Event Timeline

Charlie Jolly (charlie) requested review of this revision.Apr 16 2021, 2:58 PM
Charlie Jolly (charlie) created this revision.
Charlie Jolly (charlie) mentioned this in T86749: Geometry Node Community Additions.
Charlie Jolly (charlie) added a reviewer: Geometry Nodes.Apr 19 2021, 11:12 PM
Trung Phạm (zNight) awarded a token.May 9 2021, 11:21 AM
Jacques Lucke (JacquesLucke) requested changes to this revision.May 10 2021, 1:30 PM
Jacques Lucke (JacquesLucke) added a subscriber: Jacques Lucke (JacquesLucke).

Please move the file from C to C++ before in a separate patch.

This revision now requires changes to proceed.May 10 2021, 1:30 PM
Charlie Jolly (charlie) added a comment.May 11 2021, 1:36 PM

Conversion to C++ here: D11226: Nodes: move shader curves node to C++

Charlie Jolly (charlie) updated this revision to Diff 37420.May 24 2021, 2:04 PM

Update and rebase after separating patch.

Harbormaster completed remote builds in B14725: Diff 37420.May 24 2021, 2:05 PM
Jacques Lucke (JacquesLucke) accepted this revision.May 25 2021, 1:52 PM
Jacques Lucke (JacquesLucke) added inline comments.
source/blender/nodes/shader/nodes/node_shader_curves.cc
149

Reorder this with the line below.

149

Looks like we should add a mutex in BKE_curvemapping_init or so. It feels like there is a race condition currently. That can be done afterwards (we have similar cases already in other places).

323

reorder lines here as well

This revision is now accepted and ready to land.May 25 2021, 1:52 PM
Charlie Jolly (charlie) marked 3 inline comments as done.May 25 2021, 2:59 PM
Charlie Jolly (charlie) updated this revision to Diff 37447.May 25 2021, 3:00 PM

Address comments

Harbormaster completed remote builds in B14745: Diff 37447.May 25 2021, 3:00 PM
Jacques Lucke (JacquesLucke) accepted this revision.May 25 2021, 3:02 PM

Please add the geometry nodes tag to the commit, so that it is added here: https://developer.blender.org/project/121/item/view/655/

Charlie Jolly (charlie) closed this revision.May 25 2021, 4:46 PM
Charlie Jolly (charlie) mentioned this in rB8cd506639a78: Geometry Nodes: Add Shader Curve Nodes.

Landed: rB8cd506639a78

Charlie Jolly (charlie) added a commit: rB8cd506639a78: Geometry Nodes: Add Shader Curve Nodes.May 25 2021, 4:51 PM
Charlie Jolly (charlie) removed a commit: rB8cd506639a78: Geometry Nodes: Add Shader Curve Nodes.
Charlie Jolly (charlie) added a commit: rB8cd506639a78: Geometry Nodes: Add Shader Curve Nodes.

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
2 lines
source/
blender/
nodes/
shader/
nodes/
100 lines

Diff 37420

View Options

release/scripts/startup/nodeitems_builtins.py

Loading...
View Options

source/blender/nodes/shader/nodes/node_shader_curves.cc

Loading...