Fix T84815 : Missing preview image in compositing file output node
AbandonedPublic
Actions

Authored by Dean Jones (DeanKingsley) on Apr 16 2021, 4:58 PM.

Details

Reviewers

Jeroen Bakker (jbakker)

Maniphest Tasks

T84815: Missing preview image in compositing file output node

Diff Detail

Repository: rB Blender

Event Timeline

Dean Jones (DeanKingsley) requested review of this revision.Apr 16 2021, 4:58 PM

Dean Jones (DeanKingsley) created this revision.

Pratik Borhade (PratikPB2123) added a task: T84815: Missing preview image in compositing file output node.Apr 17 2021, 5:54 AM

Pratik Borhade (PratikPB2123) added projects: VFX & Video, Compositing.

Jeroen Bakker (jbakker) requested changes to this revision.Apr 23 2021, 10:12 AM

Jeroen Bakker (jbakker) added inline comments.

source/blender/compositor/nodes/COM_OutputFileNode.cc
41	This line does nothing? This change changes other part of the behavior. eg. files are now also written when not rendering.

This revision now requires changes to proceed.Apr 23 2021, 10:12 AM

My bad, I see now. Will get back to this as soon as I can

Hi Jeroen, I've updated the diff here. I'm unsure if this is the best fix still, in the case that a new input is planned to be previewed and isn't set to the first position. Thanks in advance!

Connect to the first connected (linked) input. If no link exist do not add a preview. For readability you can add a method add_preview_to_first_linked_input.
Remove the previewAdded from the single layer format. No need to add two previews.
Check if you have clang installed and run make format in blender source folder. Run this to ensure our code formatting rules.

This revision now requires changes to proceed.Apr 26 2021, 7:33 AM

Hi Jeroen, I'll get back to this as soon as I get the time.
I would like to clarify something. With the method, would adding it inside COM_CompositorContext.h be the best location or just keep everything inside COM_OutputFileNode.cc? I'm hesitant to change several files around.
Thank you for being patient.

Pierre Risch (prisch) added a subscriber: Pierre Risch (prisch).Mar 1 2022, 3:56 AM

Pierre Risch (prisch) mentioned this in D14219: T84815: Missing preview image in compositing file output node.Mar 2 2022, 3:44 AM

Jeroen Bakker (jbakker) mentioned this in rBe4278b72bb1a: T84815: Missing preview image in compositing file output node.Mar 21 2022, 10:57 AM