Paths

Table of Contentst

Cleanup: replace .index_range() with iter_indices(...)
Needs ReviewPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Apr 17 2021, 5:27 PM.

Details

Reviewers

Summary

My main motivation for this change is that it removes the need to add a .index_range() method to various containers.
Also the iter_indices function works with third party containers (when they have a size method).

Diff Detail

Repository

rB Blender

Branch

iter-indices (branched from master)

Build Status

Buildable 14084
Build 14084: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Apr 17 2021, 5:27 PM

Jacques Lucke (JacquesLucke) created this revision.

Harbormaster completed remote builds in B14084: Diff 36252.Apr 17 2021, 5:27 PM

Jacques Lucke (JacquesLucke) added a reviewer: Hans Goudey (HooglyBoogly).Apr 17 2021, 5:28 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

BKE_attribute_math.hh

4 lines

intern/

attribute_math.cc

2 lines

geometry_component_instances.cc

2 lines

geometry_set_instances.cc

4 lines

mesh_boolean_convert.cc

2 lines

volume_render.cc

6 lines

volume_to_mesh.cc

6 lines

blenlib/

8 lines

2 lines

12 lines

17 lines

BLI_linear_allocator.hh

2 lines

18 lines

5 lines

14 lines

5 lines

intern/

12 lines

42 lines

30 lines

10 lines

functions/

FN_generic_virtual_array.hh

5 lines

FN_multi_function.hh

2 lines

intern/

multi_function_network.cc

8 lines

multi_function_network_evaluation.cc

4 lines

multi_function_network_optimization.cc

8 lines

modifiers/

intern/

MOD_mask.cc

10 lines

MOD_nodes.cc

4 lines

nodes/

NOD_node_tree_multi_function.hh

4 lines

geometry/

nodes/

node_geo_attribute_map_range.cc

20 lines

node_geo_attribute_proximity.cc

2 lines

node_geo_attribute_randomize.cc

14 lines

node_geo_attribute_separate_xyz.cc

2 lines

node_geo_boolean.cc

2 lines

node_geo_bounding_box.cc

2 lines

node_geo_mesh_primitive_grid.cc

2 lines

node_geo_mesh_primitive_line.cc

4 lines

node_geo_point_distribute.cc

24 lines

node_geo_point_instance.cc

2 lines

node_geo_point_scale.cc

4 lines

node_geo_point_separate.cc

2 lines

node_geo_points_to_volume.cc

2 lines

Diff 36252

View Options

source/blender/blenkernel/BKE_attribute_math.hh

View Options

source/blender/blenkernel/intern/attribute_math.cc

View Options

source/blender/blenkernel/intern/geometry_component_instances.cc

View Options

source/blender/blenkernel/intern/geometry_set_instances.cc

View Options

source/blender/blenkernel/intern/mesh_boolean_convert.cc

View Options

source/blender/blenkernel/intern/volume_render.cc

View Options

source/blender/blenkernel/intern/volume_to_mesh.cc

View Options

source/blender/blenlib/BLI_array.hh

View Options

source/blender/blenlib/BLI_hash_tables.hh

View Options

source/blender/blenlib/BLI_index_mask.hh

View Options

source/blender/blenlib/BLI_index_range.hh

View Options

source/blender/blenlib/BLI_linear_allocator.hh

View Options

source/blender/blenlib/BLI_span.hh

View Options

source/blender/blenlib/BLI_string_ref.hh

View Options

source/blender/blenlib/BLI_vector.hh

View Options

source/blender/blenlib/BLI_virtual_array.hh

View Options

source/blender/blenlib/intern/delaunay_2d.cc

View Options

source/blender/blenlib/intern/mesh_boolean.cc

View Options

source/blender/blenlib/intern/mesh_intersect.cc

View Options

source/blender/blenlib/intern/string_search.cc

View Options

source/blender/functions/FN_generic_virtual_array.hh

View Options

source/blender/functions/FN_multi_function.hh

View Options

source/blender/functions/intern/multi_function_network.cc

View Options

source/blender/functions/intern/multi_function_network_evaluation.cc

View Options

source/blender/functions/intern/multi_function_network_optimization.cc

View Options

source/blender/modifiers/intern/MOD_mask.cc

View Options

source/blender/modifiers/intern/MOD_nodes.cc

View Options

source/blender/nodes/NOD_node_tree_multi_function.hh

View Options

source/blender/nodes/geometry/nodes/node_geo_attribute_map_range.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_attribute_proximity.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_attribute_randomize.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_attribute_separate_xyz.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_boolean.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_bounding_box.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_grid.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_line.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_point_distribute.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_point_instance.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_point_scale.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_point_separate.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_points_to_volume.cc

Cleanup: replace .index_range() with iter_indices(...)Needs ReviewPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 36252

source/blender/blenkernel/BKE_attribute_math.hh

source/blender/blenkernel/intern/attribute_math.cc

source/blender/blenkernel/intern/geometry_component_instances.cc

source/blender/blenkernel/intern/geometry_set_instances.cc

source/blender/blenkernel/intern/mesh_boolean_convert.cc

source/blender/blenkernel/intern/volume_render.cc

source/blender/blenkernel/intern/volume_to_mesh.cc

source/blender/blenlib/BLI_array.hh

source/blender/blenlib/BLI_hash_tables.hh

source/blender/blenlib/BLI_index_mask.hh

source/blender/blenlib/BLI_index_range.hh

source/blender/blenlib/BLI_linear_allocator.hh

source/blender/blenlib/BLI_span.hh

source/blender/blenlib/BLI_string_ref.hh

source/blender/blenlib/BLI_vector.hh

source/blender/blenlib/BLI_virtual_array.hh

source/blender/blenlib/intern/delaunay_2d.cc

source/blender/blenlib/intern/mesh_boolean.cc

source/blender/blenlib/intern/mesh_intersect.cc

source/blender/blenlib/intern/string_search.cc

source/blender/functions/FN_generic_virtual_array.hh

source/blender/functions/FN_multi_function.hh

source/blender/functions/intern/multi_function_network.cc

source/blender/functions/intern/multi_function_network_evaluation.cc

source/blender/functions/intern/multi_function_network_optimization.cc

source/blender/modifiers/intern/MOD_mask.cc

source/blender/modifiers/intern/MOD_nodes.cc

source/blender/nodes/NOD_node_tree_multi_function.hh

source/blender/nodes/geometry/nodes/node_geo_attribute_map_range.cc

source/blender/nodes/geometry/nodes/node_geo_attribute_proximity.cc

source/blender/nodes/geometry/nodes/node_geo_attribute_randomize.cc

source/blender/nodes/geometry/nodes/node_geo_attribute_separate_xyz.cc

source/blender/nodes/geometry/nodes/node_geo_boolean.cc

source/blender/nodes/geometry/nodes/node_geo_bounding_box.cc

source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_grid.cc

source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_line.cc

source/blender/nodes/geometry/nodes/node_geo_point_distribute.cc

source/blender/nodes/geometry/nodes/node_geo_point_instance.cc

source/blender/nodes/geometry/nodes/node_geo_point_scale.cc

source/blender/nodes/geometry/nodes/node_geo_point_separate.cc

source/blender/nodes/geometry/nodes/node_geo_points_to_volume.cc

Cleanup: replace .index_range() with iter_indices(...)
Needs ReviewPublic
Actions

Revision Contents
Changeset List