Fix T87615: No snapping to objects instanced by Geometry nodes
ClosedPublic
Actions

Authored by Germano Cavalcante (mano-wii) on Apr 19 2021, 10:17 PM.

Details

Reviewers

Jacques Lucke (JacquesLucke)

Group Reviewers

Geometry Nodes

Maniphest Tasks

T87615: Snapping to objects instanced by Geometry nodes

Commits

rB80536e8bae3e: Fix T87615: No snapping to objects instanced by Geometry nodes

Summary

The code of the snapping system to interact the objects in the scene only
considers instacias what comes from "DUPLI" objects.

This patch proposes to add other types of instances as it is also seen in
the BKE_object_visibility function.

(Clang formatting came by surprise).

Ref T87615

Diff Detail

Repository

rB Blender

Branch

master

Build Status

Buildable 14110
Build 14110: arc lint + arc unit

Event Timeline

Germano Cavalcante (mano-wii) requested review of this revision.Apr 19 2021, 10:17 PM

Germano Cavalcante (mano-wii) created this revision.

Harbormaster completed remote builds in B14110: Diff 36301.Apr 19 2021, 10:18 PM

Pratik Borhade (PratikPB2123) awarded a token.Apr 21 2021, 3:23 AM

LGTM.
I still have to add a more general BKE_object_has_instances or so, but that can be done separately.

This revision is now accepted and ready to land.Apr 22 2021, 1:00 PM

Closed by commit rB80536e8bae3e: Fix T87615: No snapping to objects instanced by Geometry nodes (authored by Germano Cavalcante (mano-wii)). · Explain WhyApr 22 2021, 2:58 PM

This revision was automatically updated to reflect the committed changes.

Germano Cavalcante (mano-wii) added a commit: rB80536e8bae3e: Fix T87615: No snapping to objects instanced by Geometry nodes.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

transform/

transform_snap_object.c

23 lines

Diff 36301

View Options

source/blender/editors/transform/transform_snap_object.c

Fix T87615: No snapping to objects instanced by Geometry nodesClosedPublicActions