Page MenuHome

Fix T87637: Dragging button value cancel not working
ClosedPublic

Authored by Falk David (filedescriptor) on Apr 19 2021, 10:27 PM.

Details

Summary

Dragging a number button, then holding the value and pressing escape
would not reset the value correctly.
This was because eb06ccc32462 assumed that data->value and
data->startvalue were set during dragging which they are not.

The fix moves the if statement into the section where we check if a
number was entered (number edit) making sure that we only cancel
if the button was in "string enter" mode and that the value entered
was the same as before.

Diff Detail

Repository
rB Blender
Branch
T87637 (branched from master)
Build Status
Buildable 14111
Build 14111: arc lint + arc unit

Event Timeline

Falk David (filedescriptor) requested review of this revision.Apr 19 2021, 10:27 PM
Falk David (filedescriptor) created this revision.

This seems to fix the problem for me.

This revision is now accepted and ready to land.Apr 19 2021, 11:08 PM
This revision now requires review to proceed.Apr 20 2021, 2:18 PM
This revision is now accepted and ready to land.Apr 20 2021, 2:22 PM