Differential D11022

Fix T87635: Rename shader node "Specular" to "Specular BSDF"
ClosedPublic
Actions

Authored by Pratik Borhade (PratikPB2123) on Apr 20 2021, 3:28 AM.

Details

Reviewers

Clément Foucault (fclem)

Maniphest Tasks

T87635: Rename shader node "Specular" to "Specular BSDF"

Commits

rB8c21076addf4: Fix T87635: Rename shader node "Specular" to "Specular BSDF"

Summary

Node name edited in Specular node definition

Diff Detail

Repository: rB Blender

Event Timeline

Pratik Borhade (PratikPB2123) requested review of this revision.Apr 20 2021, 3:28 AM

Pratik Borhade (PratikPB2123) created this revision.

Pratik Borhade (PratikPB2123) added a task: T87635: Rename shader node "Specular" to "Specular BSDF".

Pratik Borhade (PratikPB2123) updated this revision to Diff 36319.Apr 20 2021, 12:00 PM

Pratik Borhade (PratikPB2123) added a reviewer: Jacques Lucke (JacquesLucke).

Jacques Lucke (JacquesLucke) edited reviewers, added: Clément Foucault (fclem); removed: Hans Goudey (HooglyBoogly), Jacques Lucke (JacquesLucke).Apr 20 2021, 12:08 PM

I don't have a strong opinion about this. Maybe @Brecht Van Lommel (brecht) has one on this.

The only issue I see is that this node could be mistaken with a Glossy BSDF.

Maybe we should pick a better name for it.

This revision is now accepted and ready to land.Apr 20 2021, 5:25 PM

Fine with me.

Hi @Clément Foucault (fclem) , can you please commit the patch :)

David Johnson (dlfon99) added a subscriber: David Johnson (dlfon99).Jul 24 2021, 2:44 AM

Closed by commit rB8c21076addf4: Fix T87635: Rename shader node "Specular" to "Specular BSDF" (authored by Pratik Borhade (PratikPB2123), committed by Jeroen Bakker (jbakker)). · Explain WhyAug 4 2021, 11:23 AM

This revision was automatically updated to reflect the committed changes.

Jeroen Bakker (jbakker) added a commit: rB8c21076addf4: Fix T87635: Rename shader node "Specular" to "Specular BSDF".

Revision Contents
Changeset List

Path

Size

source/

blender/

nodes/

shader/

nodes/

node_shader_eevee_specular.c

2 lines

Diff 36307

View Options

source/blender/nodes/shader/nodes/node_shader_eevee_specular.c

Fix T87635: Rename shader node "Specular" to "Specular BSDF"ClosedPublicActions