VSE: Fix movies are reloaded after invalidation
ClosedPublic
Actions

Authored by Richard Antalik (ISS) on Apr 20 2021, 7:15 AM.

Details

Reviewers

Sergey Sharybin (sergey)

Commits

rBa43d644decb2: VSE: Fix movies are reloaded after invalidation

Summary

When cache is strip is invalidated, movie file was reloaded even if it
isn't necessary. This caused significant performance issues when strip
is being dragged under playhead.

This was caused by calling SEQ_relations_sequence_free_anim() and it
was introduced as fix for T36124.

When it is necessary to reload file because another API holds reference
to ImBuf, do this explicitly besides cache invalidation.

In rna_ColorManagedColorspaceSettings_reload_update() this was already
done, so no change is needed there.

Diff Detail

Repository

rB Blender

Branch

master

Build Status

Buildable 14116
Build 14116: arc lint + arc unit

Event Timeline

Richard Antalik (ISS) requested review of this revision.Apr 20 2021, 7:15 AM

Richard Antalik (ISS) created this revision.

Harbormaster completed remote builds in B14116: Diff 36314.Apr 20 2021, 7:15 AM

Indeed freeing anim on cache invalidation seems a wrong choice.

However, please check on the history of the line to see if it was a deliberate fix for something. Just to be sure we are not re-introducing some issue we are not immediately aware of.

In D11024#281405, @Sergey Sharybin (sergey) wrote:

However, please check on the history of the line to see if it was a deliberate fix for something. Just to be sure we are not re-introducing some issue we are not immediately aware of.

I have looked at history and it is mentioned in commit message - it was introduced as fix for T36124. In that case SEQ_relations_sequence_free_anim() is explicitly defined already.

Sergey Sharybin (sergey) accepted this revision.Apr 20 2021, 12:38 PM

This revision is now accepted and ready to land.Apr 20 2021, 12:38 PM

Closed by commit rBa43d644decb2: VSE: Fix movies are reloaded after invalidation (authored by Richard Antalik (ISS)). · Explain WhyApr 22 2021, 8:26 AM

This revision was automatically updated to reflect the committed changes.

Richard Antalik (ISS) added a commit: rBa43d644decb2: VSE: Fix movies are reloaded after invalidation.