Page MenuHome

Curve modifiers: Disable 'Apply on Spline' option if not available
ClosedPublic

Authored by Philipp Oeser (lichtwerk) on Apr 20 2021, 3:07 PM.

Details

Summary

Some curve modifiers (namely Hook, SoftBody and MeshDeform) can only work on pre-tesselated spline points.

Before the modifier UI refactor in rB9b099c86123f, users would get the
'Apply on Spline' option, but disabled and with a tip explaining why
this cant be changed. After rB9b099c86123f though, this button was
always enabled [but disfunctional] leaving the user without an
explanation why this has no effect.

Now restore this functionality since it is quite important information.
Additionally, this button now appears to be ON in these cases which
makes more sense from the user perspective (so it does not represent the
actual setting on the modifier -- this would internally be switched ON in the modifier calculation anyways though, see
'curve_get_tessellate_point')

Diff Detail

Repository
rB Blender
Branch
curve_modifier_apply_on_spline (branched from master)
Build Status
Buildable 14129
Build 14129: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Apr 20 2021, 3:07 PM
Philipp Oeser (lichtwerk) created this revision.

let the button appear to be ON (makes more sense from the user perspective)

Looks good (well as good as it can look considering this hackyness).

Maybe it makes sense to use UI_but_disable and supply the disabled hint so it shows in red.

Also, for the tooltip maybe this is a bit more clear: "This modifier can only deform control points, not the tessellated spline."

This revision is now accepted and ready to land.Apr 20 2021, 5:24 PM