Fix T87337: Text strip draws white outline
ClosedPublic
Actions

Authored by Richard Antalik (ISS) on Apr 21 2021, 7:28 AM.

Details

Reviewers

Sergey Sharybin (sergey)

Maniphest Tasks

T87337: Video editing (outline on the border of white text strip on a white background)

Commits

rB6944521d7e37: Fix T87337: Text strip draws white outline

Summary

Math for drawing font over byte buffer was incorrect. Effect can be seen
when target buffer is fully black and transparent - this results in font
color being effectively premultiplied, which causes problems when image
is composited further.

Use blend_color_mix_byte() and blend_color_mix_float() for blending.

Diff Detail

Repository

rB Blender

Branch

T87337 (branched from master)

Build Status

Buildable 14138
Build 14138: arc lint + arc unit

Event Timeline

Richard Antalik (ISS) requested review of this revision.Apr 21 2021, 7:28 AM

Richard Antalik (ISS) created this revision.

Harbormaster completed remote builds in B14138: Diff 36359.Apr 21 2021, 7:28 AM

Is always nice to use utility function instead of inlining the math!

source/blender/blenfont/intern/blf_font.c
679	I would use `unit_float_to_uchar_clamp()` here to make sure no integer overflow happens.

This revision is now accepted and ready to land.Apr 21 2021, 11:42 AM

Use unit_float_to_uchar_clamp to prevent overflow.

Harbormaster completed remote builds in B14145: Diff 36374.Apr 21 2021, 1:15 PM

The patch is accepted btw ;)

Closed by commit rB6944521d7e37: Fix T87337: Text strip draws white outline (authored by Richard Antalik (ISS)). · Explain WhyApr 22 2021, 8:25 AM

This revision was automatically updated to reflect the committed changes.

Richard Antalik (ISS) added a commit: rB6944521d7e37: Fix T87337: Text strip draws white outline.

Revision Contents
Changeset List

Path

Size

source/

blender/

blenfont/

intern/

blf_font.c

38 lines

Diff 36359

View Options

source/blender/blenfont/intern/blf_font.c

Fix T87337: Text strip draws white outlineClosedPublicActions