Differential D11036

Fix T78845: Eevee wrong material selection.
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Apr 21 2021, 10:49 AM.

Tags

Subscribers

None

Details

Reviewers

Clément Foucault (fclem)

Maniphest Tasks

T78845: Some hair particles are rendered the wrong material in EEVEE

Commits

rB2f6219c48df4: Fix T78845: Eevee wrong material selection.

Summary

In cases where the same node tree is used in different materials with
small changes, the wrong material could be selected.

Cause: Hair shaders GPU resources weren't updated and used the previous bound data.

Diff Detail

Repository: rB Blender

Event Timeline

Jeroen Bakker (jbakker) requested review of this revision.Apr 21 2021, 10:49 AM

Jeroen Bakker (jbakker) created this revision.

Harbormaster completed remote builds in B14140: Diff 36365.Apr 21 2021, 10:49 AM

Jeroen Bakker (jbakker) added a reviewer: Clément Foucault (fclem).Apr 21 2021, 10:50 AM

Jeroen Bakker (jbakker) added projects: BF Blender (2.93), EEVEE & Viewport.

Jeroen Bakker (jbakker) added inline comments.Apr 21 2021, 10:53 AM

source/blender/draw/engines/eevee/eevee_materials.c
617	Could be removed as GPUMaterial is large...

Jeroen Bakker (jbakker) retitled this revision from Fix T78845: Eevee selects wrong material. to Fix T78845: Eevee wrong material selection..Apr 21 2021, 10:53 AM

Replaced cache key with update of material data for hair shaders.

Harbormaster completed remote builds in B14146: Diff 36375.Apr 21 2021, 1:49 PM

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Apr 21 2021, 1:49 PM

Clément Foucault (fclem) accepted this revision.Apr 21 2021, 2:02 PM

This revision is now accepted and ready to land.Apr 21 2021, 2:02 PM

Closed by commit rB2f6219c48df4: Fix T78845: Eevee wrong material selection. (authored by Jeroen Bakker (jbakker)). · Explain WhyApr 23 2021, 10:05 AM

This revision was automatically updated to reflect the committed changes.

Jeroen Bakker (jbakker) added a commit: rB2f6219c48df4: Fix T78845: Eevee wrong material selection..

Revision Contents
Changeset List

Path

Size

release/

scripts/

2 lines

source/

blender/

draw/

engines/

eevee/

eevee_materials.c

3 lines

Diff 36440

release/scripts/addons

Loading...

source/blender/draw/engines/eevee/eevee_materials.c

Loading...