Page MenuHome
Differential D11051

Fix T87666: Point Instance Node crash deleting instance object Collection
AbandonedPublic
Actions

Authored by Himanshi Kalra (calra) on Apr 22 2021, 3:46 PM.

Details

Reviewers
Jacques Lucke (JacquesLucke)
Summary

Problem: Blender crashes when instance object from Collection is deleted in Point Instance Geometry Node.

Changes: Should check for either of the conditions and return.

Code Added in: D10290

Fixing Bug: T87666

Diff Detail

Repository
rB Blender
Branch
bugfix (branched from master)
Build Status
Buildable 14172
Build 14172: arc lint + arc unit

Event Timeline

Himanshi Kalra (calra) requested review of this revision.Apr 22 2021, 3:46 PM
Himanshi Kalra (calra) created this revision.
Harbormaster completed remote builds in B14172: Diff 36415.Apr 22 2021, 3:46 PM
Himanshi Kalra (calra) edited the summary of this revision. (Show Details)Apr 22 2021, 3:50 PM
Himanshi Kalra (calra) added a reviewer: Jacques Lucke (JacquesLucke).Apr 22 2021, 3:55 PM
Jacques Lucke (JacquesLucke) added a comment.Apr 22 2021, 3:57 PM

This does fix the crash, but it also makes the Geo_Crash.blend file from the original report not work (no instances are visible). So this does not seem to be the correct fix.

Dalai Felinto (dfelinto) abandoned this revision.Apr 26 2021, 12:43 PM
Dalai Felinto (dfelinto) added a subscriber: Dalai Felinto (dfelinto).

Thanks for the contribution @Himanshi Kalra (calra), but I'm closing this patch in favour of D11053

Revision Contents
Changeset List

PathSize
source/
blender/
nodes/
geometry/
nodes/
2 lines

Diff 36415

View Options

source/blender/nodes/geometry/nodes/node_geo_point_instance.cc

Loading...