Fix Action Editor unlink button when in tweak mode
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Apr 22 2021, 4:56 PM.

Details

Reviewers

Sybren A. Stüvel (sybren)
Wayde Moss (GuiltyGhost)

Maniphest Tasks

T87681: UI bugs in NLA Editor and Action Editor

Commits

rBfd29a161cc89: Fix Action Editor unlink button when in tweak mode

Summary

When in NLA tweak mode, the action unlink button in the Dopesheet /
Action Editor should be a mere shortcut to exiting tweak mode [nothing
else].

Instead, it was also clearing the action fully, not returning to the
previous edited action before going into tweak mode.

Now dont "flush" by clearing the action, instead exit tweakmode, clear
the scenes SCE_NLA_EDIT_ON flag (if this isnt done some NLA operators
like pushdown were not immediately available because their poll checked
this flag) and send appropriate notifier to have everything update nicely.

Part of T87681 (Bug 4/5/6).

Diff Detail

Repository

rB Blender

Branch

T87681_d (branched from master)

Build Status

Buildable 14174
Build 14174: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Apr 22 2021, 4:56 PM

Philipp Oeser (lichtwerk) created this revision.

Harbormaster completed remote builds in B14174: Diff 36418.Apr 22 2021, 4:56 PM

Philipp Oeser (lichtwerk) added projects: Animation & Rigging, User Interface.Apr 22 2021, 4:57 PM

Philipp Oeser (lichtwerk) added a reviewer: Wayde Moss (GuiltyGhost).Apr 22 2021, 5:01 PM

Philipp Oeser (lichtwerk) mentioned this in D12085: Fix T89805: NLA crash without active track.Jul 30 2021, 12:12 PM

Philipp Oeser (lichtwerk) mentioned this in rB333c3c92ab83: Fix T89805: NLA crash without active track.Aug 12 2021, 4:43 PM

Sybren A. Stüvel (sybren) accepted this revision.Aug 12 2021, 6:00 PM

Sybren A. Stüvel (sybren) added inline comments.

source/blender/editors/space_action/action_data.c
606–609	This works, but I do wonder why this is not always necessary after calling `BKE_nla_tweakmode_exit()`. Shouldn't that function get a scene parameter and just always clear the flag when tweakmode exits?

This revision is now accepted and ready to land.Aug 12 2021, 6:00 PM

Philipp Oeser (lichtwerk) added inline comments.Aug 13 2021, 11:05 AM

source/blender/editors/space_action/action_data.c
606–609	That sounds good, I'll investigate this further. Providing scene from RNA callback might not be possible, but if none is provided skipping of flag-clearing should not be a problem. note: I found this comment from rBf283aa61c5a5: Fix T48397: Can not bake tweaked NLA regarding the `SCE_NLA_EDIT_ON` flag: /* NOTE: technically we should also set/unset SCE_NLA_EDIT_ON flag on the * scene which is used to make polling tests faster, but this flag is weak * and can easily break e.g. by changing layer visibility. This needs to be * dealt with at some point. */ Even though this mentions the "weakness" of this flag, I'll still commit this solution here (since the "weakness" is still better then total failure).