Spreadsheet: Combine vector/color spreadsheet columns.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Apr 23 2021, 10:20 AM.

Details

Reviewers

Hans Goudey (HooglyBoogly)
Simon Thommes (simonthommes)
Dalai Felinto (dfelinto)

Maniphest Tasks

T87710: Spreadsheet: Combine vector/color columns.

Commits

rBa17ea1a66919: Spreadsheet: combine vector/color spreadsheet columns

Summary

Ref T87710.

This patch is targeted at 2.93.

The "column type" added in D10959 can simplify selecting the proper default column width, but that can be done for 3.0 only. Adding the column type here would make the patch more complex than it needs to be.

Diff Detail

Repository: rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Apr 23 2021, 10:20 AM

Jacques Lucke (JacquesLucke) created this revision.

Harbormaster completed remote builds in B14190: Diff 36442.Apr 23 2021, 10:20 AM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Apr 23 2021, 10:21 AM

Jacques Lucke (JacquesLucke) added a task: T87710: Spreadsheet: Combine vector/color columns..

cleanup

Harbormaster completed remote builds in B14191: Diff 36443.Apr 23 2021, 10:22 AM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Apr 23 2021, 10:28 AM

Jacques Lucke (JacquesLucke) added reviewers: Hans Goudey (HooglyBoogly), Simon Thommes (simonthommes), Dalai Felinto (dfelinto).

Dalai Felinto (dfelinto) accepted this revision.Apr 23 2021, 12:35 PM

Dalai Felinto (dfelinto) added 1 blocking reviewer(s): Hans Goudey (HooglyBoogly).

I find this a lot harder to easily pick up on which column is for x,y,z. An experienced user may understand that things are typically in x,y,z order but for new users this is impossible to pickup on. Same is true for other vector types like color or arbitrary vector types which can be created from custom properties/attributes. Perhaps this information can be in a tool tip or as a label in the grid cell for example |X: 1.00000|Y: 1.00000|Z: 1.00000|

I was curious how you'd do this. This way does seem like the simplest solution.
CellValue is getting rather large now unfortunately though. We should probably refactor that soon.

I think that tooltip idea would make sense in the context of other plans for the spreadsheet, I see it as something separate though.

This revision is now accepted and ready to land.Apr 23 2021, 4:26 PM

Closed by commit rBa17ea1a66919: Spreadsheet: combine vector/color spreadsheet columns (authored by Jacques Lucke (JacquesLucke)). · Explain WhyApr 26 2021, 9:10 AM

This revision was automatically updated to reflect the committed changes.

Jacques Lucke (JacquesLucke) added a commit: rBa17ea1a66919: Spreadsheet: combine vector/color spreadsheet columns.