VSE: Fix slow prefetching when strips are animated
ClosedPublic
Actions

Authored by Richard Antalik (ISS) on Apr 23 2021, 3:15 PM.

Details

Reviewers

Sergey Sharybin (sergey)

Commits

rBc704ddcb5fb4: VSE: Fix slow prefetching when strips are animated

Summary

This was caused by anim handle being reset by
DEG_evaluate_on_framechange()

Preserve anim handle by backing it up in
blender::deg::SequenceBackup

Diff Detail

Repository: rB Blender

Event Timeline

Richard Antalik (ISS) requested review of this revision.Apr 23 2021, 3:15 PM

Richard Antalik (ISS) created this revision.

Harbormaster completed remote builds in B14196: Diff 36448.Apr 23 2021, 3:15 PM

The idea is correct. Some comments about using utility functions.

source/blender/depsgraph/intern/eval/deg_eval_runtime_backup_sequence.cc
38	Use `BLI_listbase_clear()`
47	Similar to above :)
59	`!BLI_listbase_is_empty(&anims)`

Address inlines

Harbormaster completed remote builds in B14197: Diff 36449.Apr 23 2021, 3:33 PM

Sergey Sharybin (sergey) accepted this revision.Apr 23 2021, 3:46 PM

This revision is now accepted and ready to land.Apr 23 2021, 3:46 PM

Closed by commit rBc704ddcb5fb4: VSE: Fix slow prefetching when strips are animated (authored by Richard Antalik (ISS)). · Explain WhyApr 28 2021, 5:22 PM

This revision was automatically updated to reflect the committed changes.

Richard Antalik (ISS) added a commit: rBc704ddcb5fb4: VSE: Fix slow prefetching when strips are animated.

Revision Contents
Changeset List

Path

Size

source/

blender/

depsgraph/

intern/

eval/

deg_eval_runtime_backup_sequence.h

3 lines

deg_eval_runtime_backup_sequence.cc

6 lines

Diff 36614

View Options

source/blender/depsgraph/intern/eval/deg_eval_runtime_backup_sequence.h