Page MenuHome
Differential D11061

Fix "Unknown CPU" on Apple Silicon
ClosedPublic
Actions

Authored by Christian Baars (Staars) on Apr 23 2021, 5:24 PM.

Details

Reviewers
Patrick Mours (pmoursnv)
Brecht Van Lommel (brecht)
Group Reviewers
Platform: macOS
Commits
rCe083054fd818: Fix missing Cycles CPU name on macOS Arm
rB87ba01dba90b: Fix missing Cycles CPU name on macOS Arm
Summary

Use SYSCTL in macOS to get cpu_brand_name on Intel and Apple Silicon Macs.
Tested on latest Big Sur 11.2.3 on both platforms.

It should change nothing of the result on Intel Macs and finally show "Apple M1" on the latest ARM64 Macs.

Diff Detail

Event Timeline

Christian Baars (Staars) requested review of this revision.Apr 23 2021, 5:24 PM
Christian Baars (Staars) created this revision.
Ankit Meel (ankitm) edited reviewers, added: Platform: macOS; removed: BF Blender (2.93), BF Blender (3.0).Apr 23 2021, 5:26 PM
Christian Baars (Staars) mentioned this in T87728: Unknown CPU type reported for Apple M1.Apr 26 2021, 8:47 PM
Germano Cavalcante (mano-wii) added a reviewer: Patrick Mours (pmoursnv).Apr 28 2021, 5:24 PM
Germano Cavalcante (mano-wii) added subscribers: Patrick Mours (pmoursnv), Germano Cavalcante (mano-wii).

That code was introduced in rB847579b4
So, @Patrick Mours (pmoursnv) should understand well what this change does?

Patrick Mours (pmoursnv) added a comment.Apr 28 2021, 5:33 PM

I understand what it does, but I'm not familiar with macOS, so can't rate the solution. Semantically it looks good to me. So if it works I see no problem with committing this.

Brecht Van Lommel (brecht) accepted this revision.Apr 29 2021, 3:53 PM
This revision is now accepted and ready to land.Apr 29 2021, 3:53 PM
Closed by commit rB87ba01dba90b: Fix missing Cycles CPU name on macOS Arm (authored by Christian Baars (Staars), committed by Brecht Van Lommel (brecht)). · Explain WhyApr 29 2021, 4:00 PM
This revision was automatically updated to reflect the committed changes.
Brecht Van Lommel (brecht) added a commit: rB87ba01dba90b: Fix missing Cycles CPU name on macOS Arm.
Stefan Werner (swerner) added a commit: rCe083054fd818: Fix missing Cycles CPU name on macOS Arm.Jun 2 2021, 9:18 PM

Revision Contents
Changeset List

PathSize
intern/
cycles/
util/
7 lines

Diff 36458

View Options

intern/cycles/util/util_system.cpp

Loading...