Differential D11068

Replace COM_DEBUG #define with constexpr. Fixes T87035
ClosedPublic
Actions

Authored by Tyler (tsjordan) on Apr 24 2021, 7:59 PM.

Tags

None

Subscribers

Jeroen Bakker (jbakker)

Tyler (tsjordan)

Details

Reviewers

Jeroen Bakker (jbakker)

Maniphest Tasks

T87035: Replace `#ifdef COM_Debug` with constexpr function.

Commits

rBa5bb028e785c: Replace COM_DEBUG #define with constexpr. Fixes T87035

Diff Detail

Repository: rB Blender

Event Timeline

Tyler (tsjordan) requested review of this revision.Apr 24 2021, 7:59 PM

Tyler (tsjordan) created this revision.

Harbormaster completed remote builds in B14206: Diff 36472.Apr 24 2021, 8:00 PM

Tyler (tsjordan) mentioned this in T87035: Replace `#ifdef COM_Debug` with constexpr function..Apr 25 2021, 1:33 AM

Jeroen Bakker (jbakker) added inline comments.Apr 26 2021, 7:46 AM

source/blender/compositor/intern/COM_Debug.cc
44–45
54	Not needed, this is an internal method
63	Not needed this is an internal method
69–70	Move convert_started, execute_started, node_added, node_to_operations, operation_added, operation_read_write_buffer, execution_group_started and execution_group_finished into the header file. This way it will be inlined during compilation.

Jeroen Bakker (jbakker) requested changes to this revision.Apr 26 2021, 7:46 AM

This revision now requires changes to proceed.Apr 26 2021, 7:46 AM

Apply clang-format
Move COM_debug functions to h file so they inline

Harbormaster completed remote builds in B14252: Diff 36555.Apr 27 2021, 6:58 AM

Thank you for your time and effort!

This revision is now accepted and ready to land.Apr 28 2021, 8:02 AM

Closed by commit rBa5bb028e785c: Replace COM_DEBUG #define with constexpr. Fixes T87035 (authored by Tyler Shelton (tyler), committed by Jeroen Bakker (jbakker)). · Explain WhyApr 28 2021, 8:04 AM

This revision was automatically updated to reflect the committed changes.

Jeroen Bakker (jbakker) added a commit: rBa5bb028e785c: Replace COM_DEBUG #define with constexpr. Fixes T87035.

Revision Contents
Changeset List

Path

Size

source/

blender/

compositor/

1 line

intern/

95 lines

89 lines

Diff 36589

source/blender/compositor/COM_defines.h

Loading...

source/blender/compositor/intern/COM_Debug.h

Loading...

source/blender/compositor/intern/COM_Debug.cc

Loading...