Fix Simple Deform Modifier numerical precision error
ClosedPublic
Actions

Authored by Henrik Dick (weasel) on Apr 25 2021, 6:13 PM.

Details

Reviewers

Germano Cavalcante (mano-wii)
Campbell Barton (campbellbarton)

Group Reviewers

Modifiers

Maniphest Tasks

T85470: Simple Deform modifier generates ripples if set to bend mode with a very low angle

Summary

Fixes T85470

The formula used to compute the bend did subtraction of two big numbers to get the position. Changed to find the delta and add that, by rearranging the formula into a more numerically stable form.

Diff Detail

Repository: rB Blender

Event Timeline

Henrik Dick (weasel) requested review of this revision.Apr 25 2021, 6:13 PM

Henrik Dick (weasel) created this revision.

It looks safe.
But I will wait a little longer for another reviewer before committing.

This revision is now accepted and ready to land.Apr 26 2021, 3:43 PM

Campbell Barton (campbellbarton) accepted this revision.Apr 30 2021, 3:39 PM

Campbell Barton (campbellbarton) mentioned this in rBa58a8296d9da: Fix T85470: Simple deform modifier causes artifacts at low angles.Apr 30 2021, 3:41 PM

Thanks, committed rBa58a8296d9da785920575725bbb41fd5481b5d2d

Revision Contents
Changeset List

Path

Size

source/

blender/

modifiers/

intern/

MOD_simpledeform.c

6 lines

Diff 36483

View Options

source/blender/modifiers/intern/MOD_simpledeform.c

Fix Simple Deform Modifier numerical precision errorClosedPublicActions