Page MenuHome

deps_builder: add support for building zstd
ClosedPublic

Authored by Ray Molenkamp (LazyDodo) on Apr 26 2021, 12:10 AM.

Details

Diff Detail

Repository
rB Blender
Branch
tmp_zstd (branched from master)
Build Status
Buildable 14215
Build 14215: arc lint + arc unit

Event Timeline

Ray Molenkamp (LazyDodo) requested review of this revision.Apr 26 2021, 12:10 AM
Ray Molenkamp (LazyDodo) created this revision.

Any reasons not to have included needed changes to install_deps here too? they should be trivial (biggest work being to figure out name of libzstd dev package on the supported distros...)?

I don't know how be my main reasoning here, I'd rather not spend an hour fighting white space and line endings on windows in a bash script a Linux platform guy would do a better job at in 10 minutes.

Unofficial rule between the platform devs for the last few years has been "worry about your own platform only, the other (mac/linux/windows) guys are better and faster at what they do than you are" some patches go the extra mile and build and test all platforms and include install_deps, and that's fantastic, takes a load of the other devs, but it's by no means required. (I am working to getting some of these unwritten rules written down for the platform, devices and tests module, but nothing i can share at this point)

The platforms that use the deps builder all share the same script so some synchronization is required (hence @Sybren A. Stüvel (sybren) and @Sebastián Barschkis (sebbas) being reviewers here, but not you) , install_deps is generally free to work independently and has it's own check mark in the libs update thread (T88438 for this cycle) to signify that.

As the maintainer of install_deps T88438: Libraries Changes for Blender 3.0 should be the only thing you need to keep an eye on.

zstd is committed in rBL62639

I took the liberty of committing before the patch was landed, as it's a new dependency and won't be used anyway (for updates I'd be more strict about the version in Git being the same as the precompiled libs in SVN).

This revision is now accepted and ready to land.Jun 18 2021, 3:55 PM

Allright,, soooooo..... i may or may not have promised in D5799 that we'd bump it to the latest version before landing. and by "may" i mean, i did.. and I didn't update this diff to reflect that.. i'm a bad bad dev...

If it's easier, we can keep it on 1.4.9, I don't expect any relevant difference.

Rebuilding the lib for the latest version is not a problem, it's small & fast enough to do.

This revision was automatically updated to reflect the committed changes.

Update: I just committed zstd 1.5.0 to SVN (rBL62663).