Page MenuHome
Differential D11084

Fix T87771: Immediate Crash on "Edit Source" in Compositor
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Apr 26 2021, 12:05 PM.

Details

Reviewers
Jeroen Bakker (jbakker)
Clément Foucault (fclem)
Maniphest Tasks
T87771: Immediate Crash on "Edit Source" in Compositor
Commits
rB38bfa8902b24: Fix T87771: Immediate Crash on "Edit Source" in Compositor
Summary

Caused by rB278011e44d43: Fix T80748: Render Emissive Colors in Compositor Backdrop.

Lacking the exact explanation tbh, but framebuffer management since
above commit now seems to require region bind/unbind in for the operator
to be able to redraw correctly without using the same framebuffer in
multiple contexts.

Diff Detail

Repository
rB Blender

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Apr 26 2021, 12:05 PM
Philipp Oeser (lichtwerk) created this revision.
Harbormaster completed remote builds in B14227: Diff 36515.Apr 26 2021, 12:05 PM
Philipp Oeser (lichtwerk) added a project: EEVEE & Viewport.Apr 26 2021, 12:05 PM
Jeroen Bakker (jbakker) accepted this revision.Apr 26 2021, 4:21 PM

I can imagine this was failing as drawing the backdrop uses the viewport.

This revision is now accepted and ready to land.Apr 26 2021, 4:21 PM
Closed by commit rB38bfa8902b24: Fix T87771: Immediate Crash on "Edit Source" in Compositor (authored by Philipp Oeser (lichtwerk)). · Explain WhyApr 26 2021, 6:04 PM
This revision was automatically updated to reflect the committed changes.
Philipp Oeser (lichtwerk) added a commit: rB38bfa8902b24: Fix T87771: Immediate Crash on "Edit Source" in Compositor.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
interface/
2 lines

Diff 36534

View Options

source/blender/editors/interface/interface_ops.c

Loading...