Page MenuHome
Differential D11086

Fix T85889: Recursive instances result in crash.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Apr 26 2021, 1:39 PM.

Details

Reviewers
Hans Goudey (HooglyBoogly)
Maniphest Tasks
T85889: Geometry Nodes cause crash when adding same nodes to an instanced object of that node group
Commits
rB7eb9b7976ff4: Fix T85889: recursive instances result in crash
Summary

Generally, it would be good to not allow this from happening in the first place but that is quite tricky because an object does not know which other object instances it. Similar checks might be necessary in other places, but this fixes the bug already.

Diff Detail

Repository
rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Apr 26 2021, 1:39 PM
Jacques Lucke (JacquesLucke) created this revision.
Harbormaster completed remote builds in B14232: Diff 36520.Apr 26 2021, 1:39 PM
Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Apr 26 2021, 1:42 PM
Jacques Lucke (JacquesLucke) added a task: T85889: Geometry Nodes cause crash when adding same nodes to an instanced object of that node group.
Jacques Lucke (JacquesLucke) added a reviewer: Hans Goudey (HooglyBoogly).
Hans Goudey (HooglyBoogly) accepted this revision.Apr 27 2021, 6:14 AM
Hans Goudey (HooglyBoogly) added inline comments.
source/blender/blenkernel/intern/object_dupli.cc
96

IMO there should be a brief comment about the purpose of the stack, it's not the most obvious thing.

This revision is now accepted and ready to land.Apr 27 2021, 6:14 AM
Closed by commit rB7eb9b7976ff4: Fix T85889: recursive instances result in crash (authored by Jacques Lucke (JacquesLucke)). · Explain WhyApr 27 2021, 12:35 PM
This revision was automatically updated to reflect the committed changes.
Jacques Lucke (JacquesLucke) added a commit: rB7eb9b7976ff4: Fix T85889: recursive instances result in crash.

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
intern/
25 lines

Diff 36561

View Options

source/blender/blenkernel/intern/object_dupli.cc

Loading...